Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to last changes in validator #553

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Adapt to last changes in validator #553

merged 1 commit into from
Dec 12, 2022

Conversation

vjik
Copy link
Member

@vjik vjik commented Dec 11, 2022

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues -

@vjik vjik mentioned this pull request Dec 11, 2022
Merged
@what-the-diff
Copy link

what-the-diff bot commented Dec 11, 2022

  • The namespace of the RuleHandlerContainer was changed from Yiisoft\Validator\RuleHandlerContainer to
    Yiisoft\Validator\RuleHandlerResolverInterface. This is because in version 2.0, the class name has been renamed and moved into a new directory called "rule-handler-resolver".
  • In addition, there are two files that have this change: blog/config/common/validator.php and blog-api/config/common/validator.php which means that both projects need to be updated with these changes for them to work properly together when they're deployed on production servers (or any other environment).

@vjik vjik requested a review from a team December 11, 2022 18:19
@vjik vjik added the status:code review The pull request needs review. label Dec 11, 2022
@vjik vjik merged commit f57bfa5 into master Dec 12, 2022
@vjik vjik deleted the adapt-validator branch December 12, 2022 06:49
@vjik vjik mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@xepozz xepozz xepozz approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vjik @samdark @xepozz