Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate emitter from the Application #65

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Separate emitter from the Application #65

merged 1 commit into from
Feb 28, 2020

Conversation

samdark
Copy link
Member

@samdark samdark commented Feb 28, 2020

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Tests pass? ✔️
Fixed issues -

This was referenced Feb 28, 2020
Merged
Merged
@samdark samdark requested a review from a team February 28, 2020 13:51
@roxblnfk
Copy link
Member

roxblnfk commented Feb 28, 2020 •
edited

Do we need the EmitterInterface in this case?

@samdark
Copy link
Member Author

samdark commented Feb 28, 2020

@roxblnfk good question. Maybe we do not...

@terabytesoftw
Copy link
Member

terabytesoftw commented Feb 28, 2020 •
edited

I like the interface if I want to use another emitter package I could do it

@samdark samdark merged commit 993a7cb into master Feb 28, 2020
@samdark samdark deleted the separate-emitting branch February 28, 2020 18:25
@rossaddison rossaddison mentioned this pull request Sep 27, 2021
Closed
@rossaddison rossaddison mentioned this pull request Jan 26, 2022
Closed
@rossaddison rossaddison mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

@terabytesoftw terabytesoftw terabytesoftw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdark @roxblnfk @terabytesoftw