Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrustedHostsNetworkResolver - parse port from "host" directive of RFC header as well #29

Merged
merged 15 commits into from
Jun 29, 2023
Merged

TrustedHostsNetworkResolver - parse port from "host" directive of RFC header as well #29

merged 15 commits into from
Jun 29, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

@arogachev arogachev requested a review from a team June 27, 2023 06:53
@arogachev arogachev self-assigned this Jun 27, 2023
@arogachev arogachev added the type:enhancement Enhancement label Jun 27, 2023
@arogachev arogachev linked an issue Jun 27, 2023 that may be closed by this pull request
TrustedHostsNetworkResolver - parse port from "host" directive of RFC header as well #24
Closed
@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@dbe62cb). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 0578a36 differs from pull request most recent head 9ebbfbf. Consider uploading reports for the commit 9ebbfbf to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   98.70%           
  Complexity        ?      136           
=========================================
  Files             ?        2           
  Lines             ?      385           
  Branches          ?        0           
=========================================
  Hits              ?      380           
  Misses            ?        5           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from phpdoc to master June 28, 2023 10:52
@samdark samdark merged commit 081c2fa into master Jun 29, 2023
9 of 10 checks passed
@samdark samdark deleted the parse-port-from-host branch June 29, 2023 15:37
@samdark
Copy link
Member

samdark commented Jun 29, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arogachev arogachev

Labels
type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TrustedHostsNetworkResolver - parse port from "host" directive of RFC header as well
2 participants
@arogachev @samdark