Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail strategies #64

Merged
merged 70 commits into from
Nov 28, 2022
Merged

Fail strategies #64

merged 70 commits into from
Nov 28, 2022

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #59

@viktorprogger viktorprogger added the status:under development Someone is working on a pull request. label Sep 23, 2020
@viktorprogger viktorprogger added this to the 3.0.0-alpha1 milestone Sep 23, 2020
@viktorprogger viktorprogger linked an issue Sep 23, 2020 that may be closed by this pull request
Job failure strategy per channel #59
Closed
@viktorprogger viktorprogger mentioned this pull request Oct 4, 2020
Closed
@viktorprogger viktorprogger marked this pull request as ready for review November 9, 2022 22:10
@viktorprogger viktorprogger added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Nov 9, 2022
@viktorprogger viktorprogger mentioned this pull request Nov 10, 2022
Closed
samdark
samdark approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but needs README and phpdoc bad.

samdark
samdark approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 Need to fix phpdoc.

viktorprogger and others added 5 commits November 27, 2022 17:48
@viktorprogger @StyleCIBot
Convert Fail Strategies into middlewares
9abbe1f 
* Convert into middlewares, iteration 1

* Apply fixes from StyleCI

* Fix tests and naming

* Apply fixes from StyleCI

* Bugfix

* Apply fixes from StyleCI

* Style fix

* More tests and bugfixes

Co-authored-by: StyleCI Bot <bot@styleci.io>
@viktorprogger
Docs, configs and bugfixes
df81e5d
@StyleCIBot
Apply fixes from StyleCI
840fb36
@viktorprogger
Improve exception messages
41b37cc
@viktorprogger
Bugfix
6200f34
samdark
samdark approved these changes Nov 27, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/guide/error-handling.md Outdated Show resolved Hide resolved
viktorprogger and others added 3 commits November 28, 2022 11:11
@viktorprogger @samdark
Apply docs suggestions from code review
b96b8df 
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@viktorprogger
Merge remote-tracking branch 'origin/master' into fail-strategies
45b99e7 
# Conflicts:
#	tests/Integration/MiddlewareTest.php
@viktorprogger
Fix PhpDocs
1e14d7b
@viktorprogger viktorprogger merged commit c0b6143 into master Nov 28, 2022
@viktorprogger viktorprogger deleted the fail-strategies branch November 28, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romkatsu romkatsu romkatsu left review comments

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Job failure strategy per channel
4 participants
@viktorprogger @samdark @romkatsu @StyleCIBot