Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of SQLite column #24

Merged
merged 2 commits into from
May 1, 2023
Merged

Remove usage of SQLite column #24

merged 2 commits into from
May 1, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

#23 (comment)

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5a3b8d6) 97.80% compared to head (ce488e8) 97.80%.

❗ Current head ce488e8 differs from pull request most recent head 0edea52. Consider uploading reports for the commit 0edea52 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     97.80%   97.80%           
  Complexity       78       78           
=========================================
  Files             9        9           
  Lines           455      455           
=========================================
  Hits            445      445           
  Misses           10       10           
Impacted Files Coverage Δ
src/Command/RbacDbInit.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arogachev arogachev changed the title Fix usage of SQLite column Remove usage of SQLite column Apr 30, 2023
@what-the-diff
Copy link

what-the-diff bot commented Apr 30, 2023

PR Summary

  • Removal of SchemaInterface and Column usage
    Simplified the code by removing unnecessary usage of SchemaInterface and Column.
  • 'name' column type updated
    The 'name' column type is now directly set as a string with a length of 128, NOT NULL, and PRIMARY KEY, improving readability and maintenance.

@arogachev arogachev self-assigned this Apr 30, 2023
@arogachev arogachev added the type:bug Bug label Apr 30, 2023
@arogachev arogachev marked this pull request as ready for review April 30, 2023 07:26
@arogachev arogachev requested a review from a team April 30, 2023 07:26
@arogachev arogachev merged commit 9627404 into master May 1, 2023
@arogachev arogachev deleted the fix-sqlite-column branch May 1, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants