Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema manager #23

Merged
merged 56 commits into from
Jun 28, 2023
Merged

Add schema manager #23

merged 56 commits into from
Jun 28, 2023

Conversation

arogachev
Copy link
Contributor

@arogachev arogachev commented Apr 29, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues

@arogachev arogachev self-assigned this Apr 29, 2023
@arogachev arogachev added the type:task Task label Apr 29, 2023
@what-the-diff
Copy link

what-the-diff bot commented Apr 29, 2023

PR Summary

  • Renamed RbacDbInit to SchemaManager
    Updated the class name to better reflect its purpose
  • Added interface for schema manager and implemented it
    Introduced a new interface for better code organization and maintainability
  • Removed unneeded console command
    Eliminated unused command that was only necessary for tests
  • Updated references to old classes
    Ensured smooth transition by replacing all instances of old class names with the new ones

@arogachev arogachev added type:enhancement Enhancement and removed type:task Task labels Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.19 🎉

Comparison is base (5a3b8d6) 97.80% compared to head (af96341) 100.00%.

❗ Current head af96341 differs from pull request most recent head 3b151af. Consider uploading reports for the commit 3b151af to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master       #23      +/-   ##
=============================================
+ Coverage     97.80%   100.00%   +2.19%     
- Complexity       78        85       +7     
=============================================
  Files             9         8       -1     
  Lines           455       434      -21     
=============================================
- Hits            445       434      -11     
+ Misses           10         0      -10     
Impacted Files Coverage Δ
src/DbSchemaManager.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arogachev arogachev requested a review from a team April 29, 2023 08:16
@arogachev arogachev marked this pull request as ready for review April 29, 2023 08:16
src/SchemaManager.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/Mssql/SchemaManagerTest.php Outdated Show resolved Hide resolved
tests/Mysql/SchemaManagerTest.php Outdated Show resolved Hide resolved
tests/Oracle/SchemaManagerTest.php Outdated Show resolved Hide resolved
tests/Pgsql/SchemaManagerTest.php Outdated Show resolved Hide resolved
tests/Sqlite/SchemaManagerTest.php Outdated Show resolved Hide resolved
arogachev and others added 18 commits June 27, 2023 17:29
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@arogachev arogachev requested review from vjik and a team June 27, 2023 11:58
@arogachev arogachev merged commit 75a80e6 into master Jun 28, 2023
@arogachev arogachev deleted the schema-manager branch June 28, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete RBAC related tables Add info about using with manager to README
4 participants