New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve perfomance #46
Conversation
arogachev
commented
Sep 20, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ✔️ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
============================================
- Coverage 99.42% 96.18% -3.24%
- Complexity 123 149 +26
============================================
Files 9 7 -2
Lines 518 656 +138
============================================
+ Hits 515 631 +116
- Misses 3 25 +22
☔ View full report in Codecov by Sentry. |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better not to use ->getRawSql()
. And suggested little improvements.
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
…p ci] This reverts commit 1df2b5e.
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
…-perfomance # Conflicts: # src/ItemTreeTraversal/MysqlItemTreeTraversal.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍