Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perfomance #165

Closed
3 tasks
arogachev opened this issue Aug 7, 2023 · 0 comments · Fixed by #170
Closed
3 tasks

Improve perfomance #165

arogachev opened this issue Aug 7, 2023 · 0 comments · Fixed by #170
Assignees
Labels
status:under development Someone is working on a pull request. type:bug Bug
Milestone

Comments

@arogachev
Copy link
Contributor

arogachev commented Aug 7, 2023

Adaptations to changes in related packages:


For example: separate getting direct children and all (recursive).

There are different use cases.

Direct:

if (isset($this->itemsStorage->getChildren($parentName)[$childName])) {

All (recursive):

$this->getChildrenRecursive($roleName, $result);

Current DB implementations are likely incorrect and can cause performance issues.

@arogachev arogachev self-assigned this Aug 7, 2023
@vjik vjik added the type:bug Bug label Aug 8, 2023
@vjik vjik added this to the 2.0 milestone Aug 8, 2023
@arogachev arogachev added the status:under development Someone is working on a pull request. label Aug 16, 2023
@arogachev arogachev changed the title Separate getting direct children and all (recursive) Improve perfomance Aug 24, 2023
@arogachev arogachev linked a pull request Sep 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request. type:bug Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants