Ip validator #21
Closed
Ip validator #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shoman4eg
commented
May 22, 2019
shoman4eg
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | yes |
| Tests pass? | yes? |
| Fixed issues |
samdark
requested changes
May 22, 2019
| * | ||
| * @return Ip | ||
| */ | ||
| public function useSubnet($subnet): self |
There was a problem hiding this comment.
I'd introduce two methods instead:
- requireSubnet
- optionalSubnet
Also internally it makes sense to introduce three private constants instead of having true/false/null as magic values.
| * | ||
| * @return Ip | ||
| */ | ||
| public function useIpv4($ipv4): self |
There was a problem hiding this comment.
Suggested change
| public function useIpv4($ipv4): self | |
| public function allowIpv4(bool $value): self |
| * | ||
| * @return Ip | ||
| */ | ||
| public function useIpv6(bool $ipv6): self |
There was a problem hiding this comment.
Suggested change
| public function useIpv6(bool $ipv6): self | |
| public function allowIpv6(bool $value): self |
| { | ||
| $result = new Result(); | ||
| $this->ipv6 = $ipv6; |
There was a problem hiding this comment.
Suggested change
| $this->ipv6 = $ipv6; | |
| $this->allowIpv6 = $value; |
| */ | ||
| public function useIpv4($ipv4): self | ||
| { | ||
| $this->ipv4 = $ipv4; |
There was a problem hiding this comment.
Suggested change
| $this->ipv4 = $ipv4; | |
| $this->allowIpv4 = $value; |
| */ | ||
| public function useSubnet($subnet): self | ||
| { | ||
| $this->subnet = $subnet; |
There was a problem hiding this comment.
Suggested change
| $this->subnet = $subnet; | |
| $this->subnetStrategy = $subnet; |
| * | ||
| * @return Ip | ||
| */ | ||
| public function useNegation(bool $negation): self |
There was a problem hiding this comment.
Suggested change
| public function useNegation(bool $negation): self | |
| public function allowNegation(bool $value): self |
| */ | ||
| public function useNegation(bool $negation): self | ||
| { | ||
| $this->negation = $negation; |
There was a problem hiding this comment.
Suggested change
| $this->negation = $negation; | |
| $this->allowNegation = $value; |
| } | ||
|
|
||
| return $result; | ||
| return $this->validateSubnet($value); |
There was a problem hiding this comment.
It makes little sense to have a separate method in this case.
| $validator = new Ip(['ranges' => $range]); | ||
| $this->assertEquals($expectedRange, $validator->ranges); | ||
| $validator = new Ip(); | ||
| $validator->setRanges($range); |
There was a problem hiding this comment.
Suggested change
| $validator->setRanges($range); | |
| $validator->ranges($range); |
|
Closable via #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.