Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rules immutable #61

Merged
merged 1 commit into from Mar 2, 2020
Merged

Make rules immutable #61

merged 1 commit into from Mar 2, 2020

Conversation

@samdark
Copy link
Member

samdark commented Mar 2, 2020

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Tests pass? ✔️
Fixed issues #60
@samdark samdark requested a review from yiisoft/reviewers Mar 2, 2020
@kamarton

This comment has been minimized.

Copy link
Contributor

kamarton commented Mar 2, 2020

It goes against the usual interfaces in PSR, including classes in the yii-web package.

@samdark

This comment has been minimized.

Copy link
Member Author

samdark commented Mar 2, 2020

That's OK considering that adding with is harmful in this case and that method chaining without immutability is a very dangerous practice.

@samdark samdark merged commit cecfbce into master Mar 2, 2020
5 checks passed
5 checks passed
Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@samdark samdark deleted the make-rules-immutable branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.