Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rules immutable #61

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Make rules immutable #61

merged 1 commit into from
Mar 2, 2020

Conversation

samdark
Copy link
Member

@samdark samdark commented Mar 2, 2020

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Tests pass? ✔️
Fixed issues #60

@samdark samdark added the type:enhancement Enhancement label Mar 2, 2020
@samdark samdark requested a review from a team March 2, 2020 12:02
@samdark samdark mentioned this pull request Mar 2, 2020
Closed
@kamarton
Copy link
Contributor

kamarton commented Mar 2, 2020

It goes against the usual interfaces in PSR, including classes in the yii-web package.

@samdark
Copy link
Member Author

samdark commented Mar 2, 2020

That's OK considering that adding with is harmful in this case and that method chaining without immutability is a very dangerous practice.

@samdark samdark merged commit cecfbce into master Mar 2, 2020
@samdark samdark deleted the make-rules-immutable branch March 2, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samdark @kamarton