Clarify psalm types in Result
#668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Mar 6, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #668 +/- ##
======================================
Coverage ? 94.59%
Complexity ? 776
======================================
Files ? 91
Lines ? 2387
Branches ? 0
======================================
Hits ? 2258
Misses ? 129
Partials ? 0 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Mar 7, 2024
arogachev
added a commit
that referenced
this pull request
May 23, 2024
* update irc link (#663) * update docs folder link (#666) * Add methods `addErrorWithFormatOnly()` and `addErrorWithoutPostProcessing()` to `Result` object (#665) * Clarify psalm types in `Result` (#668) * Update result docs (#676) * Add `Image` validation rule (#670) Co-authored-by: Alexey Rogachev <arogachev90@gmail.com> Co-authored-by: Alexander Makarov <sam@rmcreative.ru> * Add missed params to `Image` rule options (#680) * Add date rules (#678) Co-authored-by: Alexander Makarov <sam@rmcreative.ru> * Add aspect ratio support to `Image` rule (#681) * Add aspect ratio support to `Image` rule * Apply fixes from StyleCI * Code coverage, mutants * Add detailed test cases' descriptions in data providers * Change placeholders * Work with options * Work with options 2 * More configuration checks * Fix logic, add PHPDoc * Use value object for aspect ratio * Actualize fix for mutant for absolute margin * Fix error messages * Fix new mutants * Update src/Rule/Image/ImageAspectRatio.php Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Do not use dedicated container in tests, fix last mutant --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Release version 1.3.0 * Prepare for next release * Update guides in english and Translate guides into Brazilian Portuguese (#691) * Add `Result::add()` method for merging other results to the base one (#686) * Add `Result::add()` method for merging other results to the base one * Apply fixes from StyleCI * Update PR template [skip ci] * Update src/Result.php Co-authored-by: Alexander Makarov <sam@rmcreative.ru> --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Alexander Makarov <sam@rmcreative.ru> * Add type rules and `Any` rule (#692) * Add type rules and handlers * Apply fixes from StyleCI * Mention in the docs + basic tests * Apply fixes from StyleCI * Fix copy paste [skip ci] * Test error message * Update changelog [skip ci] * Update PHPDoc [skip ci] * More tests and descriptions * Apply fixes from StyleCI * Include type in error message * Add Any rule * Apply fixes from StyleCI * Update changelog [skip ci] * Note [skip ci] * Add translations [skip ci] * Fix tests * Test attributes * Extract PHP >= 8.1 specific tests * Apply fixes from StyleCI * Extract PHP >= 8.1 specific tests 2 * Fix mutant * Update CHANGELOG.md Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Rename Any to AnyRule (review) --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Rename `Any` rule in docs (#699) * Rename AnyHandler (remaining occurence) (#701) * Add methods for getting first error messages to `Result` (#697) * Add methods for getting first error messages to `Result` * Bump coverage * Update src/Result.php Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Update src/Result.php Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Apply fixes from StyleCI * Remove newline [skip ci] * Add changelog entry [skip ci] --------- Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> Co-authored-by: StyleCI Bot <bot@styleci.io> * Translate Each rule docs into Russian (#688) * Add `Unique` rule (#695) * Add Unique rule * Apply fixes from StyleCI * More tests, messages [WIP] * Apply fixes from StyleCI * Test traslated attributes * Test using as attribute * Ready for review * Apply fixes from StyleCI * Update src/Rule/UniqueHandler.php Co-authored-by: Dmitriy Derepko <xepozz@list.ru> * Apply fixes from StyleCI * Slightly different approach * Apply fixes from StyleCI * New test case to check strict equality * Different approach * Minor adjustments * Remove comma, rename * Update changelog [skip ci] --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Dmitriy Derepko <xepozz@list.ru> Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Fix typo in array shape (#705) * Fix docs, translate brazilian portuguese (#708) Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Release version 1.4.0 * Prepare for next release * Merge fixes --------- Co-authored-by: Ihor Sychevskyi <arhell333@gmail.com> Co-authored-by: Alexey Rogachev <arogachev90@gmail.com> Co-authored-by: Alexander Makarov <sam@rmcreative.ru> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Luiz Marin <67489841+luizcmarin@users.noreply.github.com> Co-authored-by: Danil Arduanov <rylezz@gmail.com> Co-authored-by: Dmitriy Derepko <xepozz@list.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.