-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Each rule docs into Russian #688
Conversation
ArduanovDanil
commented
Apr 5, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
Fixed issues | ❌ |
docs/guide/ru/README.md
Outdated
- [Built-in rules](built-in-rules.md) | ||
- [Callback](built-in-rules-callback.md) | ||
- [Composite](built-in-rules-composite.md) | ||
- [Каждый](built-in-rules-each.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не уверен что стоит переводить так как это и название класса.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Убрал
docs/guide/ru/built-in-rules-each.md
Outdated
]); | ||
``` | ||
|
||
Комбинируя его с другим встроенным правилом `Count`, мы можем быть уверены, что количество компонентов действительно равно 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Комбинируя его с другим встроенным правилом `Count`, мы можем быть уверены, что количество компонентов действительно равно 3: | |
Комбинируя его с другим встроенным правилом `Count`, мы можем быть уверены, что компонентов ровно три: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поправил
docs/guide/ru/built-in-rules-each.md
Outdated
new Count(3), | ||
// Применяется к отдельному элементу набора. | ||
new Each( | ||
// Для одиночных правил не требуется оборачивать его в массив / итерируемый объект. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Что в данном контексте "его"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Переформулировал
docs/guide/ru/built-in-rules-each.md
Outdated
]; | ||
``` | ||
|
||
Проверяемые элементы данных не ограничиваются только "простыми значениями" - `Each` может использоваться как внутри правила `Nested` так и содержать его, имея отношения один-ко-многим и многие-ко-многим: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Про "имея отношения" не очень понятно.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В оригинале rule covering one-to-many and many-to-many relations
- я так понимаю, тут про вложенность правил друг в друга, но как это понятно написать - не знаю :( Пока вообще удалил
docs/guide/ru/built-in-rules-each.md
Outdated
]); | ||
``` | ||
|
||
Дополнительную информацию об использовании с правилом `Nested` см. в [руководстве] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Дополнительную информацию об использовании с правилом `Nested` см. в [руководстве] | |
Дополнительную информацию об использовании с правилом `Nested` смотрите в [руководстве] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поправил
Thanks! |
* update irc link (#663) * update docs folder link (#666) * Add methods `addErrorWithFormatOnly()` and `addErrorWithoutPostProcessing()` to `Result` object (#665) * Clarify psalm types in `Result` (#668) * Update result docs (#676) * Add `Image` validation rule (#670) Co-authored-by: Alexey Rogachev <arogachev90@gmail.com> Co-authored-by: Alexander Makarov <sam@rmcreative.ru> * Add missed params to `Image` rule options (#680) * Add date rules (#678) Co-authored-by: Alexander Makarov <sam@rmcreative.ru> * Add aspect ratio support to `Image` rule (#681) * Add aspect ratio support to `Image` rule * Apply fixes from StyleCI * Code coverage, mutants * Add detailed test cases' descriptions in data providers * Change placeholders * Work with options * Work with options 2 * More configuration checks * Fix logic, add PHPDoc * Use value object for aspect ratio * Actualize fix for mutant for absolute margin * Fix error messages * Fix new mutants * Update src/Rule/Image/ImageAspectRatio.php Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Do not use dedicated container in tests, fix last mutant --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Release version 1.3.0 * Prepare for next release * Update guides in english and Translate guides into Brazilian Portuguese (#691) * Add `Result::add()` method for merging other results to the base one (#686) * Add `Result::add()` method for merging other results to the base one * Apply fixes from StyleCI * Update PR template [skip ci] * Update src/Result.php Co-authored-by: Alexander Makarov <sam@rmcreative.ru> --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Alexander Makarov <sam@rmcreative.ru> * Add type rules and `Any` rule (#692) * Add type rules and handlers * Apply fixes from StyleCI * Mention in the docs + basic tests * Apply fixes from StyleCI * Fix copy paste [skip ci] * Test error message * Update changelog [skip ci] * Update PHPDoc [skip ci] * More tests and descriptions * Apply fixes from StyleCI * Include type in error message * Add Any rule * Apply fixes from StyleCI * Update changelog [skip ci] * Note [skip ci] * Add translations [skip ci] * Fix tests * Test attributes * Extract PHP >= 8.1 specific tests * Apply fixes from StyleCI * Extract PHP >= 8.1 specific tests 2 * Fix mutant * Update CHANGELOG.md Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Rename Any to AnyRule (review) --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Rename `Any` rule in docs (#699) * Rename AnyHandler (remaining occurence) (#701) * Add methods for getting first error messages to `Result` (#697) * Add methods for getting first error messages to `Result` * Bump coverage * Update src/Result.php Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Update src/Result.php Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Apply fixes from StyleCI * Remove newline [skip ci] * Add changelog entry [skip ci] --------- Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> Co-authored-by: StyleCI Bot <bot@styleci.io> * Translate Each rule docs into Russian (#688) * Add `Unique` rule (#695) * Add Unique rule * Apply fixes from StyleCI * More tests, messages [WIP] * Apply fixes from StyleCI * Test traslated attributes * Test using as attribute * Ready for review * Apply fixes from StyleCI * Update src/Rule/UniqueHandler.php Co-authored-by: Dmitriy Derepko <xepozz@list.ru> * Apply fixes from StyleCI * Slightly different approach * Apply fixes from StyleCI * New test case to check strict equality * Different approach * Minor adjustments * Remove comma, rename * Update changelog [skip ci] --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Dmitriy Derepko <xepozz@list.ru> Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Fix typo in array shape (#705) * Fix docs, translate brazilian portuguese (#708) Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Release version 1.4.0 * Prepare for next release * Merge fixes --------- Co-authored-by: Ihor Sychevskyi <arhell333@gmail.com> Co-authored-by: Alexey Rogachev <arogachev90@gmail.com> Co-authored-by: Alexander Makarov <sam@rmcreative.ru> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Luiz Marin <67489841+luizcmarin@users.noreply.github.com> Co-authored-by: Danil Arduanov <rylezz@gmail.com> Co-authored-by: Dmitriy Derepko <xepozz@list.ru>