Fix parameter type (#74)

* Fix parameter type * Apply fixes from StyleCI * Add test * Add CHANGELOG Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Alexey Rogachev <arogachev90@gmail.com>
yiisoft · Oct 20, 2022 · 1231422 · 1231422
1 parent b696309
commit 1231422
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 1.3.1 under development
 
-- no changes in this release.
+- Enh #74: Add support for integer property names (@xepozz)
 
 
 ## 1.3.0 September 22, 2022

diff --git a/src/VarDumper.php b/src/VarDumper.php
@@ -388,8 +388,11 @@ private function exportJson(mixed $var, bool $format, int $depth, int $level): m
         }
     }
 
-    private function getPropertyName(string $property): string
+    private function getPropertyName(string|int $property): string
     {
+        if (is_int($property)) {
+            return (string) $property;
+        }
         $property = str_replace("\0", '::', trim($property));
 
         if (str_starts_with($property, '*::')) {

diff --git a/tests/VarDumperTest.php b/tests/VarDumperTest.php
@@ -799,6 +799,9 @@ public function asJsonDataProvider(): array
         $incompleteObject = unserialize('O:16:"nonExistingClass":0:{}');
         $incompleteObjectId = spl_object_id($incompleteObject);
 
+        $integerPropertyObject = unserialize('O:8:"stdClass":1:{i:5;i:5;}');
+        $integerPropertyObjectId = spl_object_id($integerPropertyObject);
+
         $emptyObject = new stdClass();
         $emptyObjectId = spl_object_id($emptyObject);
 
@@ -838,6 +841,16 @@ public function asJsonDataProvider(): array
                 }
                 JSON,
             ],
+            'integer property object' => [
+                $integerPropertyObject,
+                <<<JSON
+                {
+                    "\$__id__\$": "{$integerPropertyObjectId}",
+                    "\$__class__\$": "stdClass",
+                    "5": 5
+                }
+                JSON,
+            ],
             'empty object' => [
                 $emptyObject,
                 <<<JSON