Fix parameter type #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xepozz
commented
Oct 16, 2022
xepozz
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov ReportBase: 92.02% // Head: 92.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 92.02% 92.07% +0.04%
- Complexity 150 151 +1
============================================
Files 4 4
Lines 326 328 +2
============================================
+ Hits 300 302 +2
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
samdark
reviewed
Oct 17, 2022
| @@ -388,8 +388,11 @@ private function exportJson(mixed $var, bool $format, int $depth, int $level): m | |||
| } | |||
| } | |||
|
|
|||
| private function getPropertyName(string $property): string | |||
| private function getPropertyName(string|int $property): string | |||
There was a problem hiding this comment.
vjik
requested changes
Oct 20, 2022
|
Added missing changelog entry. As for mutation tests fail, it's irrelevant to this PR's changes. Now they pass on both new commit and after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.