Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dumps for DateTime* objects (+convert data providers to generators) #89

Merged
merged 10 commits into from
Jun 4, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jun 3, 2023

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22 🎉

Comparison is base (d478f05) 92.43% compared to head (02ccf4d) 92.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
+ Coverage     92.43%   92.66%   +0.22%     
- Complexity      156      159       +3     
============================================
  Files             4        4              
  Lines           357      368      +11     
============================================
+ Hits            330      341      +11     
  Misses           27       27              
Impacted Files Coverage Δ
src/VarDumper.php 94.41% <100.00%> (+0.30%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@what-the-diff
Copy link

what-the-diff bot commented Jun 3, 2023

PR Summary

  • Added support for DateTimeInterface in VarDumper
    DateTimeInterface is now handled by VarDumper, allowing it to manage objects related to dates and times more effectively.
  • Enhanced exportInternal() method
    The exportInternal() method has been updated to handle DateTimeInterface objects and a new private function, exportDateTime(), has been introduced to improve the handling of date and time objects.

@xepozz xepozz changed the title Custom dumps for DateTime* objects Custom dumps for DateTime* objects (+convert data providers to generators) Jun 3, 2023
@samdark
Copy link
Member

samdark commented Jun 4, 2023

  1. Tests are broken.
  2. Need a line for CHANGELOG.

Base automatically changed from ident-closure to master June 4, 2023 22:28
@xepozz xepozz merged commit a9f296c into master Jun 4, 2023
@xepozz xepozz deleted the datetime branch June 4, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants