Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream & Composite handlers #95
Stream & Composite handlers #95
Changes from all commits
e58f2b3
258cbb3
744d994
ced31cb
257d216
8d0b155
54544d7
db6e45a
0a6114e
7e87045
734d9c5
c5ee52a
efbd838
8e9e9ba
a3a5c33
06b3477
af4113b
c344ac0
6c10118
7ad6b8c
36a4317
429af6f
7b35ada
0cfe382
251fc9f
51c4a28
43862cf
b670bcb
7b56f8a
d2796d0
319e9d2
e02ca9e
64c737e
a9f8dff
c19d4c4
9f572c2
9d270f7
14e59f3
8f2b075
6445954
1edd721
4dec406
eff8f8f
9fd803d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 88 in src/Handler/StreamHandler.php
Codecov / codecov/patch
src/Handler/StreamHandler.php#L88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to reproduce async behaviour in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#98
Check warning on line 127 in src/Handler/StreamHandler.php
Codecov / codecov/patch
src/Handler/StreamHandler.php#L127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.