New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream & Composite handlers #95
Conversation
PR Summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
============================================
+ Coverage 91.82% 92.39% +0.57%
- Complexity 162 189 +27
============================================
Files 5 7 +2
Lines 379 434 +55
============================================
+ Hits 348 401 +53
- Misses 31 33 +2
☔ View full report in Codecov by Sentry. |
Co-authored-by: Alexey Rogachev <arogachev90@gmail.com>
|
||
/** @psalm-suppress PossiblyNullArgument */ | ||
if (@fwrite($this->stream, $data) === false) { | ||
throw new RuntimeException('Cannot write a stream.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to reproduce async behaviour in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check #96.
* Corrections for PR number 95 * Fix Psalm * Refactor * More refactor * Partial revert * Move write to stream logic to a separate method * Use a dedicated function for getting socket protocols * Review fix related with requiring sockets php extension * Use less variables (code review fix) * Revert socket protocols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need fix static analysis
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Simple listen udp server
Simple udp write client