New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections for PR 95 #96
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## upd-handler #96 +/- ##
=================================================
+ Coverage 92.14% 92.39% +0.24%
- Complexity 189 190 +1
=================================================
Files 7 7
Lines 433 434 +1
=================================================
+ Hits 399 401 +2
+ Misses 34 33 -1
☔ View full report in Codecov by Sentry. |
PR Summary
|
src/Handler/StreamHandler.php
Outdated
} else { | ||
$this->stream = $this->uri; | ||
$hasSocketProtocol = false; | ||
foreach (self::SOCKET_PROTOCOLS as $protocol) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then it's better to call https://www.php.net/manual/en/function.stream-get-transports.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. But the list returned by this function is bigger:
[
"tcp",
"udp",
"unix",
"udg",
"ssl",
"tls",
"tlsv1.0",
"tlsv1.1",
"tlsv1.2",
"tlsv1.3",
]
Corrections for #95.