Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for PR 95 #96

Merged
merged 10 commits into from Sep 20, 2023
Merged

Corrections for PR 95 #96

merged 10 commits into from Sep 20, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

Corrections for #95.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: +0.24% 🎉

Comparison is base (9d270f7) 92.14% compared to head (6019929) 92.39%.

Additional details and impacted files
@@                Coverage Diff                @@
##             upd-handler      #96      +/-   ##
=================================================
+ Coverage          92.14%   92.39%   +0.24%     
- Complexity           189      190       +1     
=================================================
  Files                  7        7              
  Lines                433      434       +1     
=================================================
+ Hits                 399      401       +2     
+ Misses                34       33       -1     
Files Changed Coverage Δ
src/Handler/StreamHandler.php 96.00% <95.23%> (+2.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev changed the base branch from master to upd-handler September 18, 2023 06:26
@what-the-diff
Copy link

what-the-diff bot commented Sep 18, 2023

PR Summary

  • Support for PHP 8.2
    This update makes our software compatible with the new version of PHP (8.2) which will allow smoother and improved performance.

  • New Classes Added
    Two new specific components, StreamHandler and CompositeHandler, have been created. This should improve the main functioning of the application by allowing more efficient handling of particular processes.

  • Suggested Additional Installation
    We have proposed a beneficial addition to our software, ext-sockets extension, that could improve network-related operations if installed.

  • Configuration Update
    A new file composer-require-checker.json has been included, which will assist developers in managing the software's dependencies (i.e., checks for the code's need for certain external packages).

  • Change Log Update
    Modification details including new features have been documented in the CHANGELOG.md file, so users can keep track of all updates.

  • Updated User Guide
    The README.md file has been expanded with a new section that explains how to manage the output destination, making the software more convenient to use.

  • Code Refinement
    The AddDefaultValueForUndefinedVariableRector class has been removed from rector.php, implying a clean and efficient codebase.

  • Testing & Quality Assurance
    New tests have been created for the CompositeHandler and StreamHandler components, ensuring that they function correctly.

  • Additional Support for Test
    A new InMemoryHandler class has been added in the testing directory which helps to simulate and verify the correct operation of the software in a controlled environment.

@arogachev arogachev self-assigned this Sep 18, 2023
@arogachev arogachev added type:task Task status:code review The pull request needs review. labels Sep 18, 2023
} else {
$this->stream = $this->uri;
$hasSocketProtocol = false;
foreach (self::SOCKET_PROTOCOLS as $protocol) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. But the list returned by this function is bigger:

[
    "tcp",
    "udp",
    "unix",
    "udg",
    "ssl",
    "tls",
    "tlsv1.0",
    "tlsv1.1",
    "tlsv1.2",
    "tlsv1.3",
]

src/Handler/StreamHandler.php Show resolved Hide resolved
src/Handler/StreamHandler.php Show resolved Hide resolved
@arogachev arogachev merged commit 14e59f3 into upd-handler Sep 20, 2023
29 of 35 checks passed
@arogachev arogachev deleted the 95-corrections branch September 20, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:task Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants