Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sort::getCriteria instead of Sort::getOrder #98

Closed
roxblnfk opened this issue Apr 14, 2021 · 0 comments
Closed

Use Sort::getCriteria instead of Sort::getOrder #98

roxblnfk opened this issue Apr 14, 2021 · 0 comments
Labels
status:ready for adoption Feel free to implement this issue.
Milestone
1.0

Comments

@roxblnfk
Copy link
Member

yii-cycle/src/Data/Reader/EntityReader.php

Line 208 in a67841b

$newQuery->orderBy($this->sorting->getOrder());

@roxblnfk roxblnfk mentioned this issue Apr 14, 2021
Closed
@roxblnfk roxblnfk changed the title Use getCriteria instead of getOrder Use Sort::getCriteria instead of Sort::getOrder Apr 14, 2021
@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Apr 14, 2021
rustamwin added a commit that referenced this issue Apr 10, 2022
@rustamwin
Enhancements, fix #98, #129
8b7115f
@rustamwin rustamwin added this to the 2.0 milestone Apr 10, 2022
@rustamwin rustamwin mentioned this issue Apr 10, 2022
Merged
samdark pushed a commit that referenced this issue Apr 15, 2022
@rustamwin
Enhancements, Fix #98, Fix #129, Fix #123
66e2b2b
@samdark samdark closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@samdark @roxblnfk @rustamwin