Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer data related code to a separate package #192

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.78%. Comparing base (cfcc2f6) to head (ff31b75).

❗ Current head ff31b75 differs from pull request most recent head bcdaad6. Consider uploading reports for the commit bcdaad6 to get more accurate results

Files Patch % Lines
src/Command/Migration/GenerateCommand.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
+ Coverage     99.71%   99.78%   +0.07%     
+ Complexity      241      156      -85     
============================================
  Files            43       28      -15     
  Lines           702      466     -236     
============================================
- Hits            700      465     -235     
+ Misses            2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev marked this pull request as draft March 12, 2024 08:33
Copy link

what-the-diff bot commented Mar 12, 2024

PR Summary

This Pull Request involves a substantial clean-up of components in the codebase. Here are the important details:

  • Removal of a Dependency
    The "yiisoft/data" package has been removed from the project dependencies list.

  • Deletion of Documentation Files
    Three guides related to 'Entity Reader' have been removed from our documentation in English, Spanish, and Russian.

  • Removal of Data Reader Files
    Several data reading files, including EntityReader and cache-related files CachedCollection.php and CachedCount.php, have been removed from the project. These were previously necessary for reading data from a database.

  • Elimination of FilterHandler Classes
    A series of classes related to handling filters in data reading have been deleted. These include classes like EqualsHandler, GreaterThanHandler, LessThanHandler, amongst others.

  • Removal of Data Writer Files
    The 'EntityWriter' file, responsible for writing data into a database, was deleted.

  • Deletion of Testing Files
    Multiple PHPUnit testing files have been removed, including BaseData.php, EntityReaderTest.php, AllHandlerTest.php, AnyHandlerTest.php, etc. These files contained testing classes for various functions like Entity Reader, Filter Handlers, and Data Writers.

  • Deletion of Additional Testing Files
    More testing file deletions were included in this PR. These tests related to CachedCollection, CachedCount, EntityReader, various Handler functions, etc.

All these changes aim to simplify the codebase by removing unused or redundant components. This results in a leaner, more maintainable codebase.

Copy link
Member

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove links to the entity-reader.md files in ./docs/*/README.md files

@arogachev arogachev marked this pull request as ready for review March 12, 2024 13:51
Comment on lines 16 to 18
There is also an additional package providing Cycle ORM query adapter for [Yii Data](https://github.com/yiisoft/data)
data providers - [Yii Data Cycle](https://github.com/yiisoft/data-cycle). You can use it independently or in combination
with this package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be added in the ES docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but what about the translation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arogachev and others added 3 commits March 13, 2024 13:42
* Update docs [skip ci]

* Update PR template [skip ci]

* Add composer require checker

* Change version for CRC

* Fix CRC (WIP), use symfony/console directly

* Remove remaining ExitCode occurence

* Exclude PHP 8.0 from CI

* Add symfony finder as a dependency

* Add cycle/database dependency, bump versions

* Fix remaining CRC issues

* Add rector

* Apply Rector changes (CI)

* Apply fixes from StyleCI

* Min MSI 100%

* Remove remaining links [skip ci]

* Remove extra line [skip ci]

* Update .github/workflows/composer-require-checker.yml

Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>

* Revert some Rector changes

* Change push rules for CI (review fix)

* Update README.md

Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>

* Update rector.php

Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>

* Apply Rector changes (CI)

* Change rules for CI, BC (review fix)

* Drop 4 version of Psalm

---------

Co-authored-by: arogachev <arogachev@users.noreply.github.com>
Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@arogachev arogachev merged commit 2beb52f into master Mar 13, 2024
2 of 3 checks passed
@arogachev arogachev deleted the data-transfer branch March 13, 2024 09:03
@roxblnfk roxblnfk linked an issue Mar 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move data related code into another repository
4 participants