-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer data related code to a separate package #192
Conversation
arogachev
commented
Mar 12, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
============================================
+ Coverage 99.71% 99.78% +0.07%
+ Complexity 241 156 -85
============================================
Files 43 28 -15
Lines 702 466 -236
============================================
- Hits 700 465 -235
+ Misses 2 1 -1 ☔ View full report in Codecov by Sentry. |
PR SummaryThis Pull Request involves a substantial clean-up of components in the codebase. Here are the important details:
All these changes aim to simplify the codebase by removing unused or redundant components. This results in a leaner, more maintainable codebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove links to the entity-reader.md
files in ./docs/*/README.md
files
docs/en/README.md
Outdated
There is also an additional package providing Cycle ORM query adapter for [Yii Data](https://github.com/yiisoft/data) | ||
data providers - [Yii Data Cycle](https://github.com/yiisoft/data-cycle). You can use it independently or in combination | ||
with this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be added in the ES docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but what about the translation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Update docs [skip ci] * Update PR template [skip ci] * Add composer require checker * Change version for CRC * Fix CRC (WIP), use symfony/console directly * Remove remaining ExitCode occurence * Exclude PHP 8.0 from CI * Add symfony finder as a dependency * Add cycle/database dependency, bump versions * Fix remaining CRC issues * Add rector * Apply Rector changes (CI) * Apply fixes from StyleCI * Min MSI 100% * Remove remaining links [skip ci] * Remove extra line [skip ci] * Update .github/workflows/composer-require-checker.yml Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Revert some Rector changes * Change push rules for CI (review fix) * Update README.md Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Update rector.php Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru> * Apply Rector changes (CI) * Change rules for CI, BC (review fix) * Drop 4 version of Psalm --------- Co-authored-by: arogachev <arogachev@users.noreply.github.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>