[WIP] Refactoring #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rustamwin
commented
Jan 27, 2020
rustamwin
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Tests pass? | ? |
| Fixed issues | - |
|
|
xepozz
requested changes
Feb 10, 2020
|
This is part of the development, opinions are needed for initial development. The rest in a separate PRs (tests, other generators, UI, etc..) |
schmunk42
reviewed
Feb 13, 2020
xepozz
requested changes
Feb 14, 2020
| * @throws NotFoundException | ||
| * @throws GeneratorNotFoundException | ||
| */ | ||
| public function getGenerator(string $name): GeneratorInterface |
There was a problem hiding this comment.
Can we pre-cache already initialized generators into private property (e.g. $generatorsInstances)?
There was a problem hiding this comment.
Let's do it in the next PRs
samdark
reviewed
Feb 24, 2020
|
There are some improvements, then I do a separate PRs |
xepozz
approved these changes
Feb 24, 2020
rustamwin
added
status:ready for merge
|
Ready. |
samdark
approved these changes
Feb 26, 2020
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.