Add extra type declarations

yiisoft · Jul 10, 2019 · bcb5c77 · bcb5c77
1 parent b8cf687
commit bcb5c77
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/ErrorHandler/HtmlRenderer.php b/src/ErrorHandler/HtmlRenderer.php
@@ -31,7 +31,7 @@ private function renderTemplate(string $template, array $params): string
             throw new \RuntimeException("$template not found at $path");
         }
 
-        $renderer = function () use ($path, $params) {
+        $renderer = function () use ($path, $params): void {
             extract($params, EXTR_OVERWRITE);
             require $path;
         };
@@ -59,7 +59,7 @@ private function renderTemplate(string $template, array $params): string
      * Empty string if there are none.
      * @throws \Throwable
      */
-    private function renderPreviousExceptions(\Throwable $t)
+    private function renderPreviousExceptions(\Throwable $t): string
     {
         if (($previous = $t->getPrevious()) !== null) {
             return $this->renderTemplate('previousException', ['throwable' => $previous]);
@@ -111,7 +111,7 @@ private function renderCallStackItem(?string $file, ?int $line, ?string $class,
      * @return string HTML content of the rendered call stack.
      * @throws \Throwable
      */
-    private function renderCallStack(\Throwable $t)
+    private function renderCallStack(\Throwable $t): string
     {
         $out = '<ul>';
         $out .= $this->renderCallStackItem($t->getFile(), $t->getLine(), null, null, [], 1);

diff --git a/src/ErrorHandler/ThrowableRenderer.php b/src/ErrorHandler/ThrowableRenderer.php
@@ -28,7 +28,7 @@ abstract class ThrowableRenderer implements ThrowableRendererInterface
      */
     protected $request;
 
-    protected function getThrowableName(\Throwable $t)
+    protected function getThrowableName(\Throwable $t): string
     {
         $name = get_class($t);
 

diff --git a/src/ServerRequestFactory.php b/src/ServerRequestFactory.php
@@ -169,7 +169,7 @@ private function getUploadedFilesArray(array $filesArray): array
      * @param mixed $sizes file sizes provided by PHP
      * @param mixed $errors uploading issues provided by PHP
      */
-    private function populateUploadedFileRecursive(&$files, $names, $tempNames, $types, $sizes, $errors): void
+    private function populateUploadedFileRecursive(array &$files, $names, $tempNames, $types, $sizes, $errors): void
     {
         if (\is_array($names)) {
             foreach ($names as $i => $name) {