Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable foreign key constraings for sqlite. #1449

Closed
wants to merge 5 commits into from

Conversation

gleb-sternharz
Copy link

Issue #1447

@qiangxue
Copy link
Member

Could you update the CHANGELOG file accordingly? Thanks.

@gleb-sternharz
Copy link
Author

Done.

@cebe
Copy link
Member

cebe commented Sep 21, 2012

As stated in #1447 this is not supported by older sqlite versions, we need to make sure it does not break applications using old sqlite versions.

@resurtm
Copy link
Contributor

resurtm commented Sep 21, 2012

And of course, unit tests as always are very welcome! ;-)

@ghost ghost assigned resurtm Mar 26, 2013
resurtm added a commit that referenced this pull request Mar 26, 2013
@resurtm
Copy link
Contributor

resurtm commented Mar 26, 2013

Merged manually: 33763f8

@resurtm resurtm closed this Mar 26, 2013
@resurtm
Copy link
Contributor

resurtm commented Mar 26, 2013

@cebe:

we need to make sure it does not break applications using old sqlite versions

It won't. This case is unit tested (1b24643).

@cebe
Copy link
Member

cebe commented Mar 26, 2013

It won't. This case is unit tested (1b24643).

@resurtm also with sqlite < 3.7.10 ?

@resurtm
Copy link
Contributor

resurtm commented Mar 27, 2013

@cebe, i did some tests on PHP 5.2 (sqlite 3.3.7) and on PHP 5.4 (sqlite 3.7.7.1):

  1. Testing script: http://pastebin.com/dBngz3CA
  2. PHP 5.2 (sqlite 3.3.7): http://pastebin.com/6uYMNGZ5
  3. PHP 5.4 (sqlite 3.7.7.1): http://pastebin.com/q3X3vyDa

Looks good to me. Btw, note that default sqlite version bundled with the latest PHP 5.2 is 3.3.7—our unit tests are all right.

@cebe
Copy link
Member

cebe commented Mar 27, 2013

Okay, cool :) Thanks for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants