Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateValue() in CEmailValidator have no empty() check #3283

Closed
Lexxtor opened this issue Mar 20, 2014 · 2 comments · Fixed by #3318
Closed

validateValue() in CEmailValidator have no empty() check #3283

Lexxtor opened this issue Mar 20, 2014 · 2 comments · Fixed by #3318
Assignees
@samdark
Labels
Easy Pick type:bug
Milestone
1.1.16

Comments

@Lexxtor
Copy link

Lexxtor commented Mar 20, 2014 

$emailValidator = new CEmailValidator();
$result = $emailValidator->validateValue('');

$result will be False, but must be True, because $emailValidator->allowEmpty is True by default.
@samdark
Copy link
Member

samdark commented Mar 20, 2014

Issue is valid.

@Lexxtor Lexxtor mentioned this issue Mar 24, 2014
Closed
@tarasio tarasio mentioned this issue Apr 4, 2014
Merged
samdark added a commit that referenced this issue Apr 4, 2014
@samdark
Merge pull request #3318 from nukkumatti/issue-3283
26ddbd2 
Fixed #3283
@samdark samdark added this to the 1.1.15 milestone Apr 4, 2014
@samdark samdark self-assigned this Apr 4, 2014
cebe added a commit that referenced this issue Apr 22, 2014
@cebe
Merge branch 'master' into kadishmal-cubrid-database-support
cf1ada1 
* master: (789 commits)
  'summaryTagName' and 'emptyCssClass' options added to CBaseListView
  Missing entries added to CHANGELOG
  'cli' mode detection at 'CConsoleApplication' fixed
  Eager loading note added to 'Relational Query Options' docs
  Fix CSysLogRoute.php file comment
  Fixes #3324: add syslog support
  CDbConnection ODBC related fixes before merging
  Add ODBC to the requirements checker
  Fix #132: CDbConnection now supports ODBC
  Better fix for <script async="false"
  Fixed #3258
  Fixed #3283
  Remove async from list of Special Attributes so that it is possible to use async=false per issue: #3314
  typo fix in guide
  COciSchema: read column comments from another schema
  Update yii.php
  Add changes #3298 to CHANGELOG
  Added check for the existence of a link href attribute pager
  Added check for the existence of a link href attribute pager
  Update yii.php
  ...
twiesenthal pushed a commit to twiesenthal/yii that referenced this issue May 21, 2014
@tarasio
Fixed yiisoft#3283
dbc8543
@cebe
Copy link
Member

cebe commented Feb 22, 2015

This change is not correct, it breaks BC and works against the documentation. see #3764

@cebe cebe mentioned this issue Feb 22, 2015
Closed
cebe added a commit that referenced this issue Jan 5, 2016
@cebe
fixed regressin in CEmailValidator::validateValue()
8b16592 
fixes #3764, which was introduced by #3283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
Easy Pick type:bug
Projects
None yet
Milestone
1.1.16
Development

Successfully merging a pull request may close this issue.

Fixed #3283
3 participants
@samdark @cebe @Lexxtor