Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis ci] Let the pecl installer register memcache.so with PHP v5.4 or higher #1222

Merged
merged 5 commits into from
Aug 15, 2012

Conversation

DaSourcerer
Copy link
Contributor

As mentioned in #1219, the pecl installer in travis is configured well enough to handle the installation of the memcache extension all the way through the process. This pr will keep the before_script from registering memcache.so twice on PHP v5.4.

@samdark
Copy link
Member

samdark commented Aug 14, 2012

What's the difference?

@DaSourcerer
Copy link
Contributor Author

For yii? There will be two notices less in the output for the 5.4 test run. In the long run, this will also give way for separated test runs (as mentioned by @suralc in #1219)

@suralc
Copy link
Contributor

suralc commented Aug 14, 2012

@samdark
This will ease the tests of methods creating headers by themself (as CCookieCollection doessetcookie), without having to worry about, what test output what ,without the need to use the silence operator in tests or seperate classes to test them or writing workarounds.
Ex:
It allows the usage of the
@runTestsInSeparateProcesses
@runInSeparateProcess
tags in phpunit

samdark added a commit that referenced this pull request Aug 15, 2012
[travis ci] Let the pecl installer register memcache.so with PHP v5.4 or higher
@samdark samdark merged commit 283de72 into yiisoft:master Aug 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants