Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendors: phlymail's Net_IDNA was replaced by PEAR Net_IDNA2. #2183

Merged
merged 2 commits into from
Mar 8, 2013
Merged

Vendors: phlymail's Net_IDNA was replaced by PEAR Net_IDNA2. #2183

merged 2 commits into from
Mar 8, 2013

Conversation

resurtm
Copy link
Contributor

@resurtm resurtm commented Mar 8, 2013

The essence of the proposal:

There are four ways of encoding and decoding IDNs:

  1. idn_to_ascii, idn_to_unicode and idn_to_utf8 (http://www.php.net/manual/en/ref.intl.idn.php). These functions are available since and bundled with PHP 5.3, so this is the best option for Yii2.
  2. http://pear.php.net/package/Net_IDNA — obsolete and not maintained anymore PEAR library. It must not be used at all.
  3. http://pear.php.net/package/Net_IDNA2 — normal and maintained PEAR library. Best choice for PHP < 5.3 code. According to it's SVN (http://svn.php.net/viewvc/pear/packages/Net_IDNA2/trunk/) it was updated 14 months ago (January, 2012).
  4. http://phlymail.com/en/downloads/idna-convert.html — third party fork of the Net_IDNA (which was deprecated). According to it's website (http://phlymail.com/en/downloads/idna-convert.html) it was released at 2011-03-11.

We've discussed with @DaSourcerer which option is the best for Yii 1.1.* and came to opinion that it's better to switch to Net_IDNA2 since it's better maintained and unit tested.

@ghost ghost assigned samdark Mar 8, 2013
samdark added a commit that referenced this pull request Mar 8, 2013
Vendors: phlymail's Net_IDNA was replaced by PEAR Net_IDNA2.
@samdark samdark merged commit e63fd62 into yiisoft:master Mar 8, 2013
@samdark
Copy link
Member

samdark commented Mar 8, 2013

Thanks for updating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants