rework of pull request #354 on issue #124

[cebe]

cleanup of @DaSourcerer's pull request #354 on issue #124

the new CMysqlCommandBuilder overides the complete method but the only difference to the original implementation is

line 61-63 and 100-103 each:

-    $sql="UPDATE {$table->rawName} SET ".implode(', ',$fields);
+    $sql="UPDATE {$table->rawName}";
     $sql=$this->applyJoin($sql,$criteria->join);
+    $sql.=" SET ".implode(', ',$fields);

and lines 68 + 106:

-    $command=$this->_connection->createCommand($sql);
+    $command=$this->getDbConnection()->createCommand($sql);

Tested this with my application and a unit test is also attached so I think it is ready for merge now.

[qiangxue]

That's quite some duplicated code. Could you please check if other DBMS supports similar syntax? If so, we should modify CDbCommandBuilder.php directly. Even if it is not, we should still try to refactor the code to avoid copy large chunk of code.

[cebe]

Okay, will check it.

[DaSourcerer]

A little support: The command builder seems to be fine with pgsql. Oracle will need a subquery for the same functionailty. And this seems to be outright impossible all on SQLite.

[DaSourcerer]

w/o link: mssql seems to be content with what the unaltered command builder provides.

[DaSourcerer]

bump
Any news on this?

[cebe]

nope, sorry have not much time at the moment.

[DaSourcerer]

That's okay. But this has been left withoug a notice on Google Code for almost half a year before, so I just want to make sure it's not forgotten.

[cebe]

Found a better solution by overwriting applyJoin() and insert JOIN part before SET.

[DaSourcerer]

Nice. No idea why this didn't occur to me in the first place.