Updated composer depedencies to work with Codeception 5 #523
Conversation
developedsoftware
commented
Feb 25, 2022
developedsoftware
commented
| Q | A |
|---|---|
| Is bugfix? | o |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | unknown |
…s php ^7.4 || ^8.0 -> your php version (7.0.33) does not satisfy that requirement.
|
Not sure if this can even be done yet - as codception 5 requires PHP 8. Yii2 I assume will support PHP 7 for quite some time...should I just close this? |
|
@developedsoftware I think it's possible to allow both. Is there a stable release already? |
|
Yes I believe so. I will look to do that ! Thanks I always think composer is more linear than it is ! |
|
OK this should be good to go now! |
|
Requesting approval if possible. |
|
I'm worried about all the dev dependencies here... |
No different to 2.0.45? Just version numbers have been altered to allow for the codeception 5 depedencies. What would you like me to alter? |
| @@ -4,6 +4,6 @@ include: | |||
| - frontend | |||
| - backend | |||
| paths: | |||
| log: console/runtime/logs | |||
| output: console/runtime/output | |||
There was a problem hiding this comment.
is this needed, log seems just fine - and could potentially break some existing stuff?
There was a problem hiding this comment.
log is dropped in favour of output in codeception 2.3 so there should not be any breaking changes (all my tests passed locally)
See here Codeception/Codeception#4688 (comment)
My understanding was that log was transposed to output in the background for some time (for backward compatibilty before being dropped altogether which causes it to now error)
Original issue -> Codeception/Codeception#4688
|
I mean |
I dont follow?
which is also the requirement for So to me that all checks out OK? Can you clarify? |
I know what you mean when you said you worry about them dev dependencies. Yes I agree it would be nice to have a stable releases but there arent any so I am forced to use the dev branches. See here -> Codeception/Codeception#6327 Not sure how I can request a new release of the yii2 module - so the dev branch is the only way -> https://github.com/Codeception/module-yii2/releases |
|
Thanks. |
