Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer.lock file is in .gitignore #303

Closed
omzy opened this issue Jun 27, 2023 · 1 comment · Fixed by #309
Closed

composer.lock file is in .gitignore #303

omzy opened this issue Jun 27, 2023 · 1 comment · Fixed by #309
Labels
status:ready for adoption Feel free to implement this issue.
Milestone
2.0.50

Comments

@omzy
Copy link

omzy commented Jun 27, 2023

It seem in this PR https://github.com/yiisoft/yii2-app-basic/pull/262/files, the composer.lock file was added to .gitignore. I'm assuming this was a mistake? Because now, if you were to create a new project and install new dependencies, the .gitignore file doesn't get added to Git and therefore, you cannot install the locked dependency versions on other machines.

Q A
Yii version
PHP version
Operating system
@samdark
Copy link
Member

samdark commented Jun 29, 2023

Yes. That is a mistake.

@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Jun 29, 2023
@samdark samdark added this to the 2.0.49 milestone Jun 29, 2023
@bizley bizley modified the milestones: 2.0.49, 2.0.50 Aug 29, 2023
particleflux added a commit to particleflux/yii2-app-basic that referenced this issue Oct 13, 2023
@particleflux
Remove composer.lock from .gitignore
52a2437 
Fixes yiisoft#303
@particleflux particleflux mentioned this issue Oct 13, 2023
Merged
samdark pushed a commit that referenced this issue Oct 19, 2023
@particleflux
Fix #303: Remove composer.lock from .gitignore (#309)
8dd081c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
2.0.50
Development

Successfully merging a pull request may close this issue.

Remove composer.lock from .gitignore particleflux/yii2-app-basic
3 participants
@samdark @bizley @omzy