Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove composer.lock from .gitignore #309

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Remove composer.lock from .gitignore #309

merged 1 commit into from
Oct 19, 2023

Conversation

particleflux
Copy link
Contributor

composer.lock should not be git-ignored in a template project
Neither should it be committed, but it isn't :)

Fixes #303

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes - also with fresh dependencies, though CI would tell you, too
Fixed issues #303

@samdark samdark merged commit 8dd081c into yiisoft:master Oct 19, 2023
6 of 7 checks passed
@samdark
Copy link
Member

samdark commented Oct 19, 2023

Thanks.

@samdark samdark added this to the 2.0.50 milestone Oct 19, 2023
@particleflux particleflux deleted the issue-303 branch October 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.50
Development

Successfully merging this pull request may close these issues.

composer.lock file is in .gitignore
2 participants
@particleflux @samdark