Added support for the glypicons in the widgets

[klimov-paul]

Fix for yiisoft/yii2#5207
Added support for the glypicons in the widgets

[klimov-paul]

Added ability to specify icon as HTML.

[klimov-paul]

This one is more end-user friendly then #32, but affects widget internal label composition logic.

[samdark]

What if I want icons after labels?

[klimov-paul]

Yes, this is one of the problems.
The best way whould be allowing to specify label as an array, which can contain 'icon', 'encode' and 'template' options. But this will be inconsistent with existing encodeLabel and encodeLabels properties.

[klimov-paul]

For example:

echo Button::widget([
    'label' => ['ok-sign', 'Approve'],
]);
// or
echo Button::widget([
    'label' => [
        'icon' => 'ok-sign',
        'label' => '<b>Approve</b>',
        'encode' => false,
    ],
]);

[klimov-paul]

It whould be nice to hear @crisu83 opinion on this matter.

[crisu83]

Lately I've become more and more convinced that while this kind of logic is kind of nice to have, a more simple and better solution would be to have the user to add the icon in the label itself (through an icon helper of course). An example of this approach would be:

'label' => yii\bootstrap\Html::icon('ok-sign') . ' <b>Approve</b>',
'encode' => false,

[Borales]

@klimov-paul I'm on the side of @crisu83
Additionally to this, left position of the icon is hard-coded.
I think @crisu83's solution is more convenient

[klimov-paul]

Then what about #32 ? Is that what you whant?

[Borales]

@klimov-paul #32 - what if I would like to use other set of icons (e.g. font-awesome or ionicons)? This way - I will be forced to extend the base Icon class and hard-code another css-class, right?
Maybe, we could "choose" between different sets with the second parameter?

Like

yii\bootstrap\Html::icon('ok-sign') // by default = glyphicon
yii\bootstrap\Html::icon('ok-sign', ['class' => 'fa fa-']) // for font-awesome
// or even just
yii\bootstrap\Html::icon('ok-sign', ['class' => 'fa']) // almost all icon sets work like "setname setname-"

This is just a suggestion.

[klimov-paul]

You ARE able to do so. See the unit tests.

[Borales]

@klimov-paul sorry, didn't noticed that case.

[samdark]

I'm for #32.

[klimov-paul]

Closed in favour #34