yii\bootstrap\Html helper added
#34
Conversation
|
Nice idea. |
|
PR updated. |
| * @inheritdoc | ||
| * @return ActiveField the created ActiveField object | ||
| */ | ||
| public function field($model, $attribute, $options = []) |
There was a problem hiding this comment.
Isn't it safe to remove it? It does nothing other than calling parent implementation.
There was a problem hiding this comment.
It is added for IDE type-hint support.
There was a problem hiding this comment.
It could be done via @method annotation w/o actual implementation.
There was a problem hiding this comment.
Here I am using same approach as:
https://github.com/yiisoft/yii2/blob/master/framework/db/ActiveQuery.php#L128
|
Overall, it looks fine. |
| * Renders Bootstrap static form control. | ||
| * @param array $options the tag options in terms of name-value pairs. These will be rendered as | ||
| * the attributes of the resulting tag. There are also a special options: | ||
| * - encode: boolean, whether value should be HTML-encoded or not. |
There was a problem hiding this comment.
a newline is required before this list, otherwise it would not render properly.
|
except the phpdoc formatting which needs to be adjusted for all methods in BaseHtml too, it looks fine to me. |
`yii\bootstrap\Html` helper added
Fixes #42 and #43.
yii\bootstrap\Htmlhelper added.