Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise min version to PHP 7.3, check compatibility PHP 8.3. #242

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 27, 2023

PR Summary

  • Workflow specificity improved
    This PR improves how our system responds to changes in our code. Certain less relevant files have been set to be ignored, meaning they won't trigger a full system operation when they are modified. This makes our development process more efficient by not wasting resources on insignificant changes.

  • Dependency and PHP version update
    To ensure our application is up to date and secure, we've increased the minimum required PHP version to 7.3. Along with this, the 'phpunit/phpunit' dependency (one of the software's necessary components) has been updated to version ^9.6.

  • Refinements in Test Cases
    Various test files have been updated to refine how they operate. One significant change is that the 'setUp' method across files now includes a return type declaration- a change that increases the clarity of what the method should return. Another significant change is the replacement of 'assertContains' assertions with 'assertStringContainsString'. This change enhances the precision of our testing system.

  • File Deletion and Changes
    Unused files like 'tests/compatibility.php' have been removed, and any references to these files from others have also been adapted accordingly. This removal streamlines our codebase and avoids any potential confusions from outdated files.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant