-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change isActive check. #6
Conversation
Why? |
I don't think the change is correct. |
@oyajiro, it better you open an issue, which describes your problem in details. Then we will consider possible solution. |
If i understand correctly |
No need to open it now since you've explained it :) |
If such behavior is verified it should be changed to more explicit check and there should be a tests for it not to modify it back. |
already fixed by #37 |
When redis-server daemon down. open() return false in $this->_socket, and if we check isActive() we recieve true even if server not work.