Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPGRADE for PHP 7 and Twig 2 #92

Closed
samdark opened this issue Nov 3, 2017 · 6 comments
Closed

UPGRADE for PHP 7 and Twig 2 #92

samdark opened this issue Nov 3, 2017 · 6 comments
Assignees
@antgubarev
Labels
type:docs Documentation
Milestone
2.2.0

Comments

@samdark
Copy link
Member

samdark commented Nov 3, 2017

Need UPGRADE notes.
@samdark samdark added the type:docs Documentation label Nov 3, 2017
@samdark samdark added this to the 2.2.0 milestone Nov 3, 2017
@cebe
Copy link
Member

cebe commented Nov 3, 2017

also specify php version requirement in the readme.

@antgubarev
Copy link
Contributor

@samdark why 2.2.0? Maybe 2.1.2?

@samdark
Copy link
Member Author

samdark commented Nov 7, 2017

No since it breaks compatibility.

@antgubarev
Copy link
Contributor

Twig2 already in use since 2.1.1. And twig2 requirement php7. For this issue need to add only upgrade notes. Right? Compatibility will not be affected.

@samdark
Copy link
Member Author

samdark commented Nov 7, 2017

Ah... if that's so then 2.1.2.

@antgubarev antgubarev removed this from the 2.2.0 milestone Nov 7, 2017
@antgubarev
Copy link
Contributor

I made a mistake. Upgrade to Twig 2 in master branch

@antgubarev antgubarev added this to the 2.2.0 milestone Nov 7, 2017
antgubarev added a commit that referenced this issue Nov 7, 2017
@antgubarev
Merge pull request #96 from amarox/feature/92
a7df978 
add upgrade notes and fix changelog (#92)
antichris pushed a commit to antichris/yii2-twig that referenced this issue Mar 7, 2018
@antgubarev
add upgrade notes (yiisoft#92)
4ec591b
antichris pushed a commit to antichris/yii2-twig that referenced this issue Mar 7, 2018
@antgubarev
fix upgrade notes (yiisoft#92)
e7ec985
antichris pushed a commit to antichris/yii2-twig that referenced this issue Mar 7, 2018
@antgubarev
fix changelog (yiisoft#92)
fa385ea
antichris pushed a commit to antichris/yii2-twig that referenced this issue Mar 7, 2018
@antgubarev
fix mistake in changelog (yiisoft#92)
6ef1be7
antichris pushed a commit to antichris/yii2-twig that referenced this issue Mar 7, 2018
@antgubarev
Merge pull request yiisoft#96 from amarox/feature/92
01af6c6 
add upgrade notes and fix changelog (yiisoft#92)
antichris pushed a commit to antichris/yii2-twig that referenced this issue Jun 22, 2020
@antgubarev
add upgrade notes (yiisoft#92)
b30c597
antichris pushed a commit to antichris/yii2-twig that referenced this issue Jun 22, 2020
@antgubarev
fix upgrade notes (yiisoft#92)
b39f637
antichris pushed a commit to antichris/yii2-twig that referenced this issue Jun 22, 2020
@antgubarev
fix changelog (yiisoft#92)
053f86e
antichris pushed a commit to antichris/yii2-twig that referenced this issue Jun 22, 2020
@antgubarev
fix mistake in changelog (yiisoft#92)
6a72bd6
antichris pushed a commit to antichris/yii2-twig that referenced this issue Jun 22, 2020
@antgubarev
Merge pull request yiisoft#96 from amarox/feature/92
79c776b 
add upgrade notes and fix changelog (yiisoft#92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antgubarev antgubarev

Labels
type:docs Documentation
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@samdark @cebe @antgubarev