Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.1 changes JSON_PRETTY_PRINT indentation? #12489

Closed
cebe opened this issue Sep 7, 2016 · 5 comments
Closed

PHP 7.1 changes JSON_PRETTY_PRINT indentation? #12489

cebe opened this issue Sep 7, 2016 · 5 comments
Assignees
@SilverFire
Labels
type:bug Bug
Milestone
2.0.11

Comments

@cebe
Copy link
Member

cebe commented Sep 7, 2016

What steps will reproduce the problem?

Failing test, see https://travis-ci.org/yiisoft/yii2/jobs/158310722#L431-L436

What is the expected result?

see normal indentation as in other PHP versions.

What do you get instead?

Wrong indentation, however I am unable to reproduce this on 3v4l: https://3v4l.org/m3Xjo

Additional info

Q A
Yii version 2.0.10-dev
PHP version 7.1 on travis
@cebe cebe added type:bug Bug status:to be verified Needs to be reproduced and validated. labels Sep 7, 2016
@cebe cebe added this to the 2.0.10 milestone Sep 7, 2016
@cebe
Copy link
Member Author

cebe commented Sep 7, 2016

looks like it is related to https://bugs.php.net/bug.php?id=66025 but that context does not really apply here.

cebe added a commit that referenced this issue Sep 7, 2016
@cebe
Allow PHP 7.1 to fail until #12489 is fixed
2c3e3f3
rob006 added a commit to rob006/yii2-dev that referenced this issue Oct 5, 2016
@rob006
Skip failing test in PHP 7.1.
d17d663 
Refs yiisoft#12489
rob006 added a commit to rob006/yii2-dev that referenced this issue Oct 5, 2016
@rob006
Skip failing test in PHP 7.1.
e026283 
Refs yiisoft#12489
@rob006 rob006 mentioned this issue Oct 5, 2016
Closed
@rob006
Copy link
Contributor

rob006 commented Oct 5, 2016

It is PHP bug: https://3v4l.org/reS06

I've made a PR that skips test with failing Json::encode() for PHP 7.1: #12684 - now all tests are green.

@samdark samdark modified the milestones: 2.0.11, 2.0.10 Oct 12, 2016
@SilverFire
Copy link
Member

As @rob006 mentioned here, the bug is solved but Travis still has outdated PHP version, so 2c3e3f3 can not be reverted right now

@rob006
Copy link
Contributor

rob006 commented Nov 5, 2016

@SilverFire This fix is not yet released - this should be fixed when 6th RC of PHP 7.1 comes out (~November 10th).

@SilverFire
Copy link
Member

Ah, fine. Thank you for clarifying!

@rob006 rob006 mentioned this issue Nov 11, 2016
Merged
@SilverFire SilverFire self-assigned this Nov 12, 2016
@SilverFire SilverFire removed the status:to be verified Needs to be reproduced and validated. label Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilverFire SilverFire

Labels
type:bug Bug
Projects
None yet
Milestone
2.0.11
Development

No branches or pull requests
4 participants
@samdark @cebe @SilverFire @rob006