Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help option does not work in sub-module command #13071

Closed
haimanman opened this issue Nov 25, 2016 · 1 comment
Closed

Help option does not work in sub-module command #13071

haimanman opened this issue Nov 25, 2016 · 1 comment
Assignees
@samdark
Labels
complexity:easy type:bug Bug
Milestone
2.0.11

Comments

@haimanman
Copy link

Since 2.0.10, Yii2 add a help option for command controllers by default, but when the command is in submodule, that dose not work.

Fixing this is very simple, just modify yii\console\Controller#L125,
change $this->id to $this->uniqueId.
@cebe cebe added type:bug Bug status:ready for adoption Feel free to implement this issue. complexity:easy labels Nov 25, 2016
@cebe cebe added this to the 2.0.x milestone Nov 25, 2016
@cebe
Copy link
Member

cebe commented Nov 25, 2016

thanks for reporting this, do you want to send a pull request to fix it?

@arogachev arogachev mentioned this issue Nov 26, 2016
Merged
@cebe cebe modified the milestones: 2.0.11, 2.0.x Nov 26, 2016
@cebe cebe added status:under development Someone is working on a pull request. and removed status:ready for adoption Feel free to implement this issue. labels Nov 26, 2016
@samdark samdark closed this as completed Nov 27, 2016
@samdark samdark self-assigned this Nov 27, 2016
@samdark samdark removed the status:under development Someone is working on a pull request. label Nov 27, 2016
samdark pushed a commit that referenced this issue Nov 27, 2016
@arogachev @samdark
Fixes #13071: Help option for commands was not working in modules
e705519
SilverFire pushed a commit to SilverFire/yii2 that referenced this issue Nov 29, 2016
@arogachev @SilverFire
Fixes yiisoft#13071: Help option for commands was not working in modules
4cbf501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
complexity:easy type:bug Bug
Projects
None yet
Milestone
2.0.11
Development

No branches or pull requests
3 participants
@samdark @cebe @haimanman