Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration templates do not work with namespace naming convention #17437

Closed
Isitar opened this issue Jul 16, 2019 · 2 comments
Closed

Migration templates do not work with namespace naming convention #17437

Isitar opened this issue Jul 16, 2019 · 2 comments
Assignees
@bizley
Labels
type:bug Bug
Milestone
2.0.24

Comments

@Isitar
Copy link
Contributor

Isitar commented Jul 16, 2019

What steps will reproduce the problem?

php yii migrate/create 'common\migrations\CreateNewsTable' --fields="hello:int"

What is the expected result?

a migration with the create_table template

What do you get instead?

an empty migration

Additional info

it doesnt work because the preg_match does not work for this naming convention (line 392 onwards in MigrateController)

Q A
Yii version 2.0.22
PHP version 7.3
Operating system Windows
@samdark samdark added help wanted status:ready for adoption Feel free to implement this issue. type:bug Bug labels Jul 16, 2019
@bizley
Copy link
Member

bizley commented Jul 16, 2019

I'm on it.

@Isitar
Copy link
Contributor Author

Isitar commented Jul 16, 2019

@bizley do not forget the template files itself.

@samdark samdark removed help wanted status:ready for adoption Feel free to implement this issue. labels Jul 16, 2019
@samdark samdark added the status:under development Someone is working on a pull request. label Jul 16, 2019
@bizley bizley mentioned this issue Jul 20, 2019
Merged
@samdark samdark added this to the 2.0.24 milestone Jul 23, 2019
@samdark samdark removed the status:under development Someone is working on a pull request. label Jul 23, 2019
@samdark samdark closed this as completed Jul 23, 2019
samdark pushed a commit that referenced this issue Jul 23, 2019
@samdark
Fix #17437: Fixed generating namespaced migrations
e50a07c
@antichris antichris mentioned this issue May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizley bizley

Labels
type:bug Bug
Projects
None yet
Milestone
2.0.24
Development

No branches or pull requests
3 participants
@samdark @bizley @Isitar