Helpers refactoring

[samdark]

Moved file and path related methods from StringHelper to FileHelper, renamed StringHelper byte methods not to be misused as string methods

[qiangxue]

I think we should keep basename and dirname in StringHelper. They are about string manipulation, not file system manipulation. They are often used for strings not related with file paths. We have discussed about this before.

[samdark]

I've got at least three people complaining about FS-related stuff is in StringHelper and I feel bad about these methods being in this helper as well. Maybe another helper called "path" or something?

[qiangxue]

Suggest naming it as byteLength(). We always use full words in names other than those inherited from existing PHP function names.

[qiangxue]

The functions are provided really just for string manipulation. As you can see, they are used to extract part of the string from class names, etc., which has nothing to do with file systems. I don't think we should create a new class to hold them. The class FileHelper only deals with file systems.

[armpogart]

I often use basename for string manipulation that has nothing to do with files directly. So it's not very logical to place it in FileHelper. Though in native PHP it is in Filesystem functions, so the first place to search for that function is File related class.

[egorpromo]

I think basename() and dirname() should be in Yii class. They are special functions and could be both in StringHelper and in FileHelper at the same time.

[mikehaertl]

I have to second this: I'd never have expected these methods in StringHelper. Even if it's only string manipulation: The manipulation performed is clearly filesystem related.

Following this logic, the dirname() method from PHP would also be in the string section of the PHP manual instead of the filesystem section, as it's also just performing some string manipulation. This is not the case.

[klimov-paul]

StringHelper::dirname and StringHelper::basename are served for the namespace manipulation mainly.

[cebe]

@mikehaertl for file system you can use the PHP functions basename() and dirname(). The helper is there because the PHP functions do not work on namespaces.

[mikehaertl]

I understand that. Still I don't really see these methods as generic string related methods. So StringHelper really feels wrong. A class like yii\helpers\Namespace would be way more clean IMO.