Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BaseMailerTest class #17721

Merged
merged 5 commits into from
Dec 11, 2019
Merged

fix BaseMailerTest class #17721

merged 5 commits into from
Dec 11, 2019

Conversation

yus-ham
Copy link
Contributor

@yus-ham yus-ham commented Dec 8, 2019

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues

@samdark samdark added the pr:missing usecase It is not clear what is the use case for the pull request. label Dec 9, 2019
@yii-bot
Copy link

yii-bot commented Dec 9, 2019

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework.

Could you supply us with a use case please? Please be as detailed as possible and show some code!

Thanks!

This is an automated comment, triggered by adding the label pr:missing usecase.

@yus-ham
Copy link
Contributor Author

yus-ham commented Dec 9, 2019

My testing env resulting errors:

There were 6 errors:

1) yiiunit\framework\mail\BaseMailerTest::testSetupView
yii\base\Exception: Failed to create directory "/media/xubuncup/905C5F905C5F7048/cup/www/.dev/osp/yii2/tests/runtime/yiiunit\framework\mail\BaseMailerTest_27890": mkdir(): Invalid argument

@samdark
Copy link
Member

samdark commented Dec 9, 2019

What are your operating system and file system?

@samdark samdark closed this Dec 9, 2019
@samdark samdark reopened this Dec 9, 2019
@samdark samdark added status:need more info and removed pr:missing usecase It is not clear what is the use case for the pull request. labels Dec 9, 2019
@yiisoft yiisoft deleted a comment from yii-bot Dec 9, 2019
@yus-ham
Copy link
Contributor Author

yus-ham commented Dec 9, 2019

Here

xubuncup@ThinkPad-E440:/media/xubuncup/905C5F905C5F7048/cup/www/spionam-2.2$ php -v
PHP 7.3.12-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Nov 28 2019 07:37:16) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.12, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.12-1+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies

@samdark samdark added this to the 2.0.31 milestone Dec 9, 2019
@samdark
Copy link
Member

samdark commented Dec 9, 2019

OK. Looks valid.

@samdark samdark requested a review from a team December 10, 2019 18:47
@samdark samdark merged commit d59c60f into yiisoft:master Dec 11, 2019
@samdark
Copy link
Member

samdark commented Dec 11, 2019

Merged. Thanks!

@yus-ham yus-ham deleted the master branch December 12, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants