Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created GitHub "tests" action #17822

Merged
merged 4 commits into from
Jan 29, 2020
Merged

Created GitHub "tests" action #17822

merged 4 commits into from
Jan 29, 2020

Conversation

simialbi
Copy link
Contributor

@simialbi simialbi commented Jan 22, 2020

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Tests pass?
Fixed issues #17802

See it in action: https://github.com/simialbi/yii2/runs/402852766

@samdark samdark requested a review from a team January 22, 2020 19:42
@samdark samdark added the status:code review The pull request needs review. label Jan 22, 2020
Copy link
Contributor

@schmunk42 schmunk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@samdark samdark merged commit a777c2e into yiisoft:master Jan 29, 2020
@samdark
Copy link
Member

samdark commented Jan 29, 2020

Let's try it live. @simialbi thank you for it!

@rob006
Copy link
Contributor

rob006 commented Jan 30, 2020

So we don't run tests for PHP 5.4 and PHP 5.5 now?

@samdark
Copy link
Member

samdark commented Jan 30, 2020

Yeah... shivammathur/setup-php#169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants