19324 dropdownlist selection for boolean attributes

[adnandautovic]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	#19324

@WinterSilence Just one question about the order of $strict: Should the comparison with == really be the strict one? Comparing with strcmp appears more strict to me, but for now I implemented your original suggestion. What do you think?

[adnandautovic]

Comparing with strcmp appears more strict to me, but for now I implemented your original suggestion. What do you think?

In accordance with how yii\helpers\BaseArrayHelper::isIn handles $strict, I have now inverted the original proposal. Now, for $strict = false, the comparison is done with ==.

[WinterSilence]

@adnandautovic my solution works differently i.e. I not co-author

[WinterSilence]

@adnandautovic please add more test cases, for example, case from your issue: renderSelectOptions(false, ['No', 'Yes'], ['prompt' => 'Please select'])

[WinterSilence]

ArrayHelper::isIn((string)$key, $selection, $strict) this typing is incorrect: same result in strict and non-strict mode.

[adnandautovic]

ArrayHelper::isIn((string)$key, $selection, $strict) this typing is incorrect: same result in strict and non-strict mode.

That's true, thank you. I took a look at this and it was caused by previous fixes for wrong default selections in d39d3ed and in e49a52f.
In fact, it appears that the fix in e49a52f was faulty and the casting should have been removed in that commit.

Unfortunately, in order to do this properly then, I would have to change all three functions, checkboxList, radioList and renderSelectOptions.

I will see how I get along with this, but that definitely expands the scope of this issue.

[WinterSilence]

@adnandautovic invalid order in array: ['Please select', No, Yes]

[adnandautovic]

@adnandautovic invalid order in array: ['Please select', No, Yes]

Sorry, I don't understand? This particular test is not failing. Old tests for dropDownList, radioList and checkBoxList are failing, leading me to believe that I should just leave everything other than renderSelectOptions as it is.

[WinterSilence]

@adnandautovic look to HTML returning from updated BaseHtml::renderSelectOptions()

[adnandautovic]

@adnandautovic look to HTML returning from updated BaseHtml::renderSelectOptions()

Thank you, I think I will be able to take a look next week.

In the meantime, I think the conversion to (string) has something to do with

yii2/framework/helpers/BaseHtml.php

Lines 1874 to 1876 in 8f4a7b6

	if (ArrayHelper::isTraversable($selection)) {
	$selection = array_map('strval', ArrayHelper::toArray($selection));
	}

but I will have to check in more detail next time.

[adnandautovic]

@adnandautovic look to HTML returning from updated BaseHtml::renderSelectOptions()

I think the order is fine, actually.

In the meantime, I think the conversion to (string) has something to do with

yii2/framework/helpers/BaseHtml.php

Lines 1874 to 1876 in 8f4a7b6

	if (ArrayHelper::isTraversable($selection)) {
	$selection = array_map('strval', ArrayHelper::toArray($selection));
	}

In hindsight, this is obvious from d39d3ed.

ArrayHelper::isIn((string)$key, $selection, $strict) this typing is incorrect: same result in strict and non-strict mode.

This has turned out to not be the case (see the tests I added in 8f4a7b6). The results in strict and non-strict mode are different with the type casting and in fact the type casting is required.

Anyway, I have now added a failing test to demonstrate the impossibility of performing a non-strict check for a traversable selection containing a boolean, i.e. [false], without explicitly handling the case of a boolean selection in renderSelectOptions.

The way I see it, there are two options:

1. Ignore that, because apparently no one has had a need for that so far.
2. Add code to separately handle the case where $selection contains a boolean.

I prefer the first, but both would be fine by me.

[WinterSilence]

@adnandautovic nope, you still don't understand how work typing: your array [true => 'Yes', false => 'No'] convert to [1 => 'Yes', 0 => 'No'] i.e. ['No', 'Yes']. Your expected HTML is invalid:

$expected = <<<'EOD'
<option value="">Please select</option>
<option value="1">Yes</option>
<option value="0" selected>No</option>
EOD;

[adnandautovic]

@adnandautovic nope, you still don't understand how work typing: your array [true => 'Yes', false => 'No'] convert to [1 => 'Yes', 0 => 'No'] i.e. ['No', 'Yes']. Your expected HTML is invalid:

$expected = <<<'EOD'
<option value="">Please select</option>
<option value="1">Yes</option>
<option value="0" selected>No</option>
EOD;

As you can see from the tests that ran in the CI runner, the order is fine as far as php is concerned.
However, if you have some personal preference as to the order you want to see here, I can change that.

[adnandautovic]

As you can see from the tests that ran in the CI runner, the order is fine as far as php is concerned. However, if you have some personal preference as to the order you want to see here, I can change that.

@WinterSilence for your convenience, I have commented out the one failing test that I added on purpose. As you can see, all tests run successfully now, even with the old html. But as I said, I can change it if you like.

[WinterSilence]

@adnandautovic Your current solution is valid, but work slow, better solution is fix expected HTML.

[bizley]

Thank you.