-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composer.json #19752
Update composer.json #19752
Conversation
DarkVlad16
commented
Jan 30, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | Fixed old version of inputmask |
composer.json
Outdated
@@ -76,7 +76,7 @@ | |||
"ezyang/htmlpurifier": "^4.6", | |||
"cebe/markdown": "~1.0.0 | ~1.1.0 | ~1.2.0", | |||
"bower-asset/jquery": "3.6.*@stable | 3.5.*@stable | 3.4.*@stable | 3.3.*@stable | 3.2.*@stable | 3.1.*@stable | 2.2.*@stable | 2.1.*@stable | 1.11.*@stable | 1.12.*@stable", | |||
"bower-asset/inputmask": "~3.2.2 | ~3.3.5", | |||
"bower-asset/inputmask": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using *
is dangerous. It's better to add another version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
*
is dangerous. It's better to add another version.
Okay, but why unit tests failed on php8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but why unit tests failed on php8?
Failures are not InputMask related.
https://github.com/yiisoft/yii2/actions/runs/4041727523/jobs/6948596350#step:11:149
So, May you add this pull request to master version? Cause old version of inputmask not supports multiple masks and other features. Or how can I override it, to use new version? |
To override it with a version which is actually not compatible you can use
But it's a hack, you need to make sure it is compatible with the widget. |
Closed in favor #19963 |