Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bower-asset/inputmask, bower-asset/punycode. #19963

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Update bower-asset/inputmask, bower-asset/punycode. #19963

merged 2 commits into from
Sep 22, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@terabytesoftw terabytesoftw linked an issue Sep 21, 2023 that may be closed by this pull request
@what-the-diff
Copy link

what-the-diff bot commented Sep 21, 2023

PR Summary

  • Updated bower-asset/inputmask library in composer.json
    The version of the bower-asset/inputmask library used in our project has been updated. We have moved from previous versions "~3.2.2" or "~3.3.5" to the newer version "~5.0.8". However, we maintain backward compatibility with the old versions by still supporting "~3.2.2" and "~3.3.5"

  • Updated bower-asset/punycode library in composer.json
    We have also updated the version of the bower-asset/punycode library. We moved from the old "1.3." version to the updated "2.2." version. Like before, backward compatibility with the older version "1.3.*" is still maintained.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -28.98% ⚠️

Comparison is base (81f3033) 48.95% compared to head (a028baf) 19.97%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19963       +/-   ##
===========================================
- Coverage   48.95%   19.97%   -28.98%     
===========================================
  Files         445      445               
  Lines       42811    42593      -218     
===========================================
- Hits        20957     8507    -12450     
- Misses      21854    34086    +12232     

see 249 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw requested a review from a team September 21, 2023 14:39
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Sep 21, 2023
@bizley
Copy link
Member

bizley commented Sep 22, 2023

Could we have it in ascending order?

@bizley bizley merged commit 7576761 into yiisoft:master Sep 22, 2023
49 of 50 checks passed
@ezoterik
Copy link
Contributor

It seems that this PR broke MaskedInputAsset - #19988 (comment), #19986

@terabytesoftw terabytesoftw deleted the update-bower-inputmask-punycode branch October 14, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest update bower-asset/inputmask and bower-asset/punycode
3 participants