toolbar UI updates #2320
toolbar UI updates #2320
Conversation
added home icon removed separators with summary sections to make browsing with the panel more intuitive updated version number display, now also shown as label
| </a> | ||
| </div> | ||
| <div class="yii-debug-toolbar-block"> | ||
| <?= Html::a('PHP ' . $panel->data['php']['version'], ['phpinfo'], ['title' => 'Show phpinfo()']) ?> |
There was a problem hiding this comment.
Why remove the link to phpinfo?
There was a problem hiding this comment.
Because it drives you away from your site. When you click through the debug toolbar this links sends you to a dead end page. But we could move the button on the configuration view up. A modal with the phpinfo() contents would be nice here, btw.
And IMO it's also more intuitive to have just one destination for the links in the toolbar, it's way easier to recognize how the toolbar is connected to the views.
There was a problem hiding this comment.
I think before we have better solution for showing phpinfo, we should keep the existing solution. It's better than nothing.
Also, from end user point of view, it doesn't matter how toolbar is connected to the views. It's more important for them to see that different block points to different URL.
There was a problem hiding this comment.
What's about opening the phpinfo with target='phpinfo' in a new tab and readd the separator?
Or how do you like this solution (Note: button-style changed to btn-info) ... see screen.
There was a problem hiding this comment.
Yes, adding target is fine. We should add back the separator. It's fine using btn-info.
|
Thanks! |
|
I think there's no need for home icon in on-page toolbar. |
|
Yeah, I noticed that too. But then I thought this might be useful if you are in a sub-page. |
Exactly. And should be visible everywhere to have a consistent look. |
|
Nah, any well-designed website should provide an easy way to get to the front page. Usually it's clicking on logo. Home icon presence may give developer false assurance that navigation is OK even in case there's no link on logo. |
So, how do you get to the front-page from the debug section? |
|
Debug section is OK. I'm talking about website toolbar. |
|
I'm talking about the debug section, which you reach only via the toolbar. And there's no way back to the (frontend) home page. Since you stated that every well-designed website should have an easy way to get to the home page, I find it logical to add a "home" icon to the toolbar, which serves as a "universal" logo in the debug section. |
|
Yes, in debug section it's fine but it appears at the website as well and has no good use there. |
|
One thing is sub-pages as mentioned, another thing would be pages with broken links, while developing or debugging, another thing is look and feel and the home icon is always on the same place and is not hidden on only one page. PS: We could remove the header from Gii completely and have the same (backend-style) UI everywhere. That would lay out a slick layout foundation for all Yii2 backend extensions. |
Screens