merge ActiveRelation into ActiveQuery #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow extending only one class to add scopes, fixes #2146 TODO: - [ ] adjust guide docs - [ ] adjust README files of extensions - [ ] finish work and fix test breaks
|
Great job! Should we also merge |
|
They are but it is good to separate the logic imo. This way you see which methods are for which kind of query by just checking from which trait they come for example. It also still possible to create AR with an extra relation class if there is any need. |
cebe
added a commit
that referenced
this pull request
Feb 21, 2014
WIP merge ActiveRelation into ActiveQuery
|
Updated the docs and merged. |
|
Should the changes in .travis.yml and composer.json really be in there? :o |
|
They are not related to this change but I made them while noticing that the test chain was broken a bit when working local so I fixed it. |
|
👍 |
qiansen1386
pushed a commit
to qiansen1386/yii2
that referenced
this pull request
Mar 9, 2014
WIP merge ActiveRelation into ActiveQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow extending only one class to add scopes, fixes #2146
TODO: