Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added yii\bootstrap\ButtonDropdown::iconOptions to customize button icon #3096

Closed
wants to merge 1 commit into from
Closed

Added yii\bootstrap\ButtonDropdown::iconOptions to customize button icon #3096

wants to merge 1 commit into from

Conversation

jom
Copy link
Contributor

@jom jom commented Apr 14, 2014

No description provided.

@tonydspaniard
Copy link
Contributor

@jom whats the benefit?

@jom
Copy link
Contributor Author

jom commented Apr 15, 2014

I wanted to be able to override the locked in caret and instead use something like fa-angle-down (from FontAwesome). Caret is too small for what I'm using this for.

I was just going to put in an attribute for the CSS class itself, but wanted to be consistent with the rest of the extension.

@qiangxue qiangxue added this to the 2.0 RC milestone Apr 16, 2014
@artemzakholodilo
Copy link

You mean something like this i class="fa fa-home">

@jom
Copy link
Contributor Author

jom commented Apr 21, 2014

Yes, although the fa-home icon probably isn't what I would choose for a drop down menu. Which is why I added the property iconOptions to be able to customize this tag. Not sure what else needs to be discussed; pretty minor change. I just don't think it should be locked into caret. I have it default to that if no class is specified.

@tonydspaniard
Copy link
Contributor

Maybe instead of iconOptions attribute it should be a special part of options like we do on other widget -i.e. Nav

@creocoder
Copy link
Contributor

Vote for options name. iconOptions is not generic name. What if i do not have icons there?

@samdark
Copy link
Member

samdark commented Jun 9, 2014

@creocoder can you work on a pull request? It seems current one is kinda old one.

@creocoder
Copy link
Contributor

@samdark Will do.

@cebe cebe removed this from the 2.0 RC milestone Jul 24, 2014
@klimov-paul
Copy link
Member

Closed in favor of more generic issue #5207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants