Pgsql driver implementation (update 4) #505

gevik · 2013-06-06T11:02:48Z

Updated the suggested comments, please review again

samdark · 2013-06-06T11:07:14Z

framework/yii/db/Connection.php

@@ -343,6 +343,8 @@ protected function createPdoInstance()
 			$driver = strtolower(substr($this->dsn, 0, $pos));
 			if ($driver === 'mssql' || $driver === 'dblib' || $driver === 'sqlsrv') {
 				$pdoClass = 'yii\db\mssql\PDO';
+			} else if ($driver === 'pgsql') {


Need to change, Netbeans settings :(

qiangxue · 2013-06-06T11:17:29Z

Do we really need the PDO class?

samdark · 2013-06-06T11:17:31Z

framework/yii/db/pgsql/PDO.php

+
+	/**
+	 * Returns value of the last inserted ID.
+	 * @param string|null $sequence the sequence name. Defaults to null.


What does null mean here?

If you call getLastInsertedId without inserting a record first then, this method returns null since internally postgresql returns null.

Question was about $sequence, not about return value.

gevik · 2013-06-06T11:19:54Z

The PDO class is the correct place to implement the schema switching functionality to my opinion.

samdark · 2013-06-06T11:23:48Z

framework/yii/db/pgsql/PDO.php

+				}
+			}
+			if (isset($options[self::OPT_DEFAULT_SCHEMA])) {
+				$schema = trim($options[self::OPT_DEFAULT_SCHEMA]);


Is it possible that default schema is set to multiple spaces? If not then we can use !empty($options[self::OPT_DEFAULT_SCHEMA]) instead of isset and trim and empty string check.

This check is to make sure we have a default schema set even if the option exist with en empty value or when the option has a whitespace as a value.

qiangxue · 2013-06-06T11:30:34Z

It seems to me we don't really need the custom PDO class because setting search path and default schema can both be done in the afterOpen event of Connection if needed.

samdark · 2013-06-06T11:31:28Z

framework/yii/db/pgsql/QueryBuilder.php

+ * @author Gevik Babakhani <gevikb@gmail.com>
+ * @since 2.0
+ */
+class QueryBuilder extends \yii\db\QueryBuilder {


{ should be at the next line

Refactored == null to is_null == '' to empty(...)

qiangxue · 2013-06-06T14:31:28Z

I still don't understand why we need the custom PDO here. We don't have it in 1.1. Is there any particular problem that we need to have a custom PDO to solve?

Ragazzo · 2013-06-06T14:50:43Z

This was in outdated diff, so maybe you did not check it:
also 3 constants (in PDO class, constants realted to search path and default schema) above must be public properties. Please also note this one #205. And in Schema class it default schema must be a property.

gevik · 2013-06-06T17:57:48Z

I have created updates as suggested in the comment.Please review again.

Ragazzo · 2013-06-06T18:33:52Z

I have created updates as suggested in the comment.Please review again.

still constants presents in classes, or about what comment you were talking about?

gevik · 2013-06-06T19:32:04Z

@qiangxue I was under impression that the schema changing/seeting functionality should be as low level as possible. Changing or setting database schema is something that you do only once and to my option it should be set and passed to PDO my configuration. In event of someone needing to set it manually, then they can use the PDO->setSchemaSearchPath.

command since postgres does not accept db creation in multiline statement.

qiangxue · 2013-06-06T20:48:28Z

I think we should drop the custom PDO class. The features it adds are not available for other DBMS, and they can be accomplished via the existing Connection::afterOpen event.

gevik · 2013-06-07T20:42:52Z

Removed the custom PDO and added defaultSchema as public property. Please review

qiangxue · 2013-06-07T20:45:52Z

framework/yii/db/pgsql/Schema.php

+		try {
+			$constraints = $this->db->createCommand($sql)->queryAll();
+		} catch (\Exception $e) {
+			return false;


Should not catch exceptions because it will hide the reason why the query fails.

I missed that. I have removed it. thanks.

Pgsql driver implementation (update 4)

qiangxue · 2013-06-07T21:13:45Z

Good job! Thanks!

gevik · 2013-06-08T07:03:35Z

@mark, I hope you get this message. I have looked in the comments but
could not find issues logged by you. Could you provide more info?
Perhaps I missed something.

On 6/8/13 5:10 AM, Mark wrote:

@qiangxue https://github.com/qiangxue why problems that i've
described here and in separated issue, was not fixed and i was
ignored? This problems extremely important.

—
Reply to this email directly or view it on GitHub
#505 (comment).

samdark · 2013-06-08T07:46:40Z

framework/yii/db/pgsql/Schema.php

+	);
+
+	/**
+	 * Creates a query builder for the MySQL database.


MySQL → PostgreSQL

Ragazzo · 2013-06-08T10:28:33Z

@gevik everythng is ok, i was a little bit lost in this big number of commits ;) sorry. Thanks for the pgsql support :)

Gevik Babakhani and others added 12 commits May 29, 2013 00:01

Added initial unit testing files for the pgsql driver.

c30eae6

Save point: WIP implementing db schema functionality.

4602b57

Savepoint: WIP implementing columns

103621a

Savepoint, implementing fkeys.

97270a3

Added last insert value to pgsql PDO

04ebd12

Savepoint WIP QueryBuilder!

cbde22a

Added table based sequence.

5a38036

Removed unused columns.

18218c4

Merge remote branch 'upstream/master' into pgsql-driver

eebdfd2

Merge remote branch 'upstream/master' into pgsql-driver

3d79d99

Added foreign keys and cleanup internal pg types

70e9731

Merge remote branch 'upstream/master' into pgsql-driver

cceb5b1

samdark reviewed Jun 6, 2013
View reviewed changes

Fixed several formatting issues.

5a587d1

Refactored == null to is_null == '' to empty(...)

Gevik Babakhani added 2 commits June 6, 2013 19:29

Merge branch 'pgsql-driver' of github.com:gevik/yii2 into pgsql-driver

e4448be

Refactored types to be compatible with 1.1

e505566

gevik closed this Jun 6, 2013

gevik reopened this Jun 6, 2013

Gevik Babakhani added 2 commits June 6, 2013 21:14

Removed commented and unused pgsql datatype mappings.

9982d93

Replaces spaces with tabs.

0fd390c

Gevik Babakhani added 2 commits June 6, 2013 22:19

Added db creation for travis CI This needs to be done in two seperate

b5513c8

command since postgres does not accept db creation in multiline statement.

Added missing postgres user to the travis config.

dbe84ac

Gevik Babakhani added 2 commits June 6, 2013 22:59

Force travis to create the pgsql test db

8b61ab7

Removed custom pgsql PDO and added defaultSchema as public property.

879b494

qiangxue reviewed Jun 7, 2013
View reviewed changes

gevik added 2 commits June 7, 2013 22:54

Removed false exception catching.

d07fd39

Removed the config setting that should not have been commited.

b6d5a90

qiangxue added a commit that referenced this pull request Jun 7, 2013

Merge pull request #505 from gevik/pgsql-driver

51972f2

Pgsql driver implementation (update 4)

qiangxue merged commit 51972f2 into yiisoft:master Jun 7, 2013

qiangxue mentioned this pull request Jun 7, 2013

Implement PostgreSQL database driver #2

Closed

samdark reviewed Jun 8, 2013
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pgsql driver implementation (update 4) #505

Pgsql driver implementation (update 4) #505

gevik commented Jun 6, 2013

samdark Jun 6, 2013

gevik Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark Jun 6, 2013

gevik Jun 6, 2013

samdark Jun 6, 2013

gevik commented Jun 6, 2013

samdark Jun 6, 2013

gevik Jun 6, 2013

qiangxue commented Jun 6, 2013

samdark Jun 6, 2013

gevik Jun 6, 2013

qiangxue commented Jun 6, 2013

Ragazzo commented Jun 6, 2013

gevik commented Jun 6, 2013

Ragazzo commented Jun 6, 2013

gevik commented Jun 6, 2013

qiangxue commented Jun 6, 2013

gevik commented Jun 7, 2013

qiangxue Jun 7, 2013

gevik Jun 7, 2013

qiangxue commented Jun 7, 2013

gevik commented Jun 8, 2013

samdark Jun 8, 2013

gevik Jun 8, 2013

gevik Jun 8, 2013

Ragazzo commented Jun 8, 2013

Pgsql driver implementation (update 4) #505

Pgsql driver implementation (update 4) #505

Conversation

gevik commented Jun 6, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiangxue commented Jun 6, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gevik commented Jun 6, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiangxue commented Jun 6, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiangxue commented Jun 6, 2013

Ragazzo commented Jun 6, 2013

gevik commented Jun 6, 2013

Ragazzo commented Jun 6, 2013

gevik commented Jun 6, 2013

qiangxue commented Jun 6, 2013

gevik commented Jun 7, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiangxue commented Jun 7, 2013

gevik commented Jun 8, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ragazzo commented Jun 8, 2013