-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query helper method for filter values containing operators #8505
Closed
Closed
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
277a6fd
Query helper method for filter values containing operators
lennartvdd 631e3d3
more sensible comment
lennartvdd 8702027
Update CHANGELOG.md
lennartvdd cbca646
Method name according to yii2 convention
lennartvdd f2dcdd6
reflact method name change in CHANGELOG.md
lennartvdd 68943a1
use PR # instead of issue # in CHANGELOG.md
lennartvdd a6e4c9a
Reflect method name change in test..
lennartvdd 5e7ace0
move RDBMS specific method to yii\db\Query
lennartvdd 143ba81
Update CHANGELOG.md
lennartvdd c81ff5c
support method chaining like andFilterWhere()
lennartvdd 4d52f4e
Update comment
lennartvdd 10af910
Merge branch 'master' into queryCompare
lennartvdd e6d4a4f
use $this instead of static in phpdoc [skip ci]
lennartvdd d6833b8
Merge branch 'master' into queryCompare
lennartvdd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail for NOSQL queries such as
yii\elasticsearhc\Query
oryii\mongodb\Query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True.. it's RDBMS specific. Would moving this method out of the generic QueryTrait to yii\db\Query suffice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could try to port it to the noSQL implementations. Will do that for redis and ES.