[Work in progress] I18n icu #917

samdark · 2013-09-28T18:31:03Z

Make tests pass on PHP 5.3 and PHP 5.4
add some more test for compex and edge cases
fix Yii code to use params w/o { and } in Yii::t.

qiangxue · 2013-09-28T18:34:20Z

framework/yii/i18n/I18N.php

-			$message = $this->applyPluralRules($message, $params[0], $language);
-			if (!isset($params['{n}'])) {
-				$params['{n}'] = $params[0];
+		if (class_exists('MessageFormatter', false) && preg_match('~{\s*[\d\w]+\s*,~u', $message)) {


Does it mean that every message translation will go through MessageFormatter? Will this cause performance issue?

No. There's regexp that checks if it's something more than just plain interpolation and only then calls MessageFormatter.

coveralls · 2013-09-28T18:35:35Z

Coverage increased (+0.07%) when pulling dafbeda on i18n-icu into b873f9f on master.

qiangxue · 2013-09-28T18:36:17Z

docs/guide/i18n.md

+```php
+$username = 'Alexander';
+echo \Yii::t('app', 'Hello, {username}!', array(
+	'username' => $username,


Is it {username} or username? If the latter, then we should fix all other similar usage in Yii.

coveralls · 2013-09-29T01:16:22Z

Coverage decreased (-0.04%) when pulling abc0df6 on i18n-icu into b873f9f on master.

coveralls · 2013-09-29T01:23:02Z

Coverage decreased (-0.11%) when pulling abc0df6 on i18n-icu into b873f9f on master.

samdark · 2013-09-30T09:58:19Z

framework/yii/i18n/MessageFormatter.php

+	 * @param array $args The array of values to insert into the format string.
+	 * @return string The pattern string with placeholders replaced.
+	 */
+	private static function replaceNamedArguments($pattern, $args)


Need help with this one. See broken tests with PHP 5.3 or 5.4.

Came up with a solution to go through the pattern string and replace all relevant parts but leave out others. (3h work) Tests are passing :)

cebe · 2013-10-15T20:33:51Z

framework/yii/i18n/I18N.php

-				$params['{n}'] = $params[0];
+		if (class_exists('MessageFormatter', false) && preg_match('~{\s*[\d\w]+\s*,~u', $message)) {
+			$formatter = new MessageFormatter($language, $message);
+			if ($formatter === null) {


how can $formatter be null here?

It's null if pattern is incorrect and can't be consumed by ICU.

Also if this class is our extended version of MessageFormatter? Am I right that this is only possible with PHP internal classes?

Not sure about it. Try with '' as a message.

verified. works.

cebe · 2013-10-16T03:22:57Z

framework/yii/i18n/MessageFormatter.php

+	{
+		return (
+			!defined('INTL_ICU_VERSION') ||
+			version_compare(INTL_ICU_VERSION, '48.0.0', '<') ||


Need to check whether 48 is correct here. On my system I get 4.8.1.1 when doing echo INTL_ICU_VERSION . "\n";
PHP Version is 5.3.10-1ubuntu3.8

On Windows:

50.1.2 on 5.5

49.1.2 on 5.3

49.1.2 on 5.4

also confirm on Ubuntu PHP Version => 5.5.3-1ubuntu2
php -r "echo INTL_ICU_VERSION;"

4.8.1.1

@samdark how is the intl version relevant for the fix?

looks like it is save to compare the number without dots:

4.8.1.1 -> 4811 50.1.2 -> 5012 49.1.2 -> 4912

Found the reason for this. They changed version numbering after 4.8 release: http://site.icu-project.org/download

coveralls · 2013-10-16T03:30:18Z

Coverage increased (+0.91%) when pulling 150b936 on i18n-icu into b873f9f on master.

coveralls · 2013-10-16T04:00:35Z

Coverage increased (+0.97%) when pulling 2eb5abb on i18n-icu into b873f9f on master.

coveralls · 2013-10-16T14:09:39Z

Coverage increased (+1.24%) when pulling bbcee32 on i18n-icu into b873f9f on master.

* master: (103 commits) fixed broken test after whitespace changes in view Removed the extra EOLs. I add new line in methods that render code in the head and for body GII update button style GII create object button style [skip ci] Fixes #980: Changed the default way of generating action URLs for ActionColumn. View default value for $params adjusted cubrid version in schema quote removed cubrid env from tavis.yml simplified cubrid db install on travis fixed cubrid schema test for pdo type fixed validator test break added cubrid specific pdo type casting Updated FileValidator tests Better AR connection init in tests Removed @codeCoverageIgnore no xss for attribute error messages that contain {value} Clientvalidation {value} was not what has been validated moved getPdoType() to Schema. optimized datepick js code. ...

coveralls · 2013-10-16T20:22:58Z

Coverage increased (+0.51%) when pulling 677893e on i18n-icu into e574f10 on master.

samdark · 2013-10-16T20:36:12Z

Found a bug in PHP 5.5 in progress: https://bugs.php.net/bug.php?id=65920 Our wrapper fixes it.

…provided at all (https://bugs.php.net/bug.php?id=65920).

…bundled versions are always the same ones for the same PHP versions

coveralls · 2013-10-16T20:46:20Z

Coverage increased (+0.53%) when pulling da8f179 on i18n-icu into e574f10 on master.

coveralls · 2013-10-16T20:57:21Z

Coverage increased (+0.53%) when pulling da8f179 on i18n-icu into e574f10 on master.

coveralls · 2013-10-16T21:11:13Z

Coverage increased (+0.52%) when pulling bf7a084 on i18n-icu into e574f10 on master.

coveralls · 2013-10-16T21:59:18Z

Coverage increased (+0.58%) when pulling 71e2dcc on i18n-icu into e574f10 on master.

… for the most complex test pattern

[Work in progress] I18n icu

samdark · 2013-10-16T22:21:30Z

@cebe thanks a lot for handling ICU expressions grammar. Merged.

coveralls · 2013-10-16T22:21:56Z

Coverage remained the same when pulling 6b65ef5 on i18n-icu into e574f10 on master.

cebe · 2013-10-16T22:22:03Z

My Pleasure :)

samdark added 3 commits September 28, 2013 16:30

Used intl ICU for message translation

bf722c0

Merge branch 'master'

9212c16

More i18n tests, docs, added check to skip fixes where possible

dafbeda

samdark mentioned this pull request Sep 28, 2013

I18N: Use ICU expressions in strings in Yii::t translations #880

Closed

qiangxue reviewed Sep 28, 2013
View reviewed changes

samdark mentioned this pull request Sep 29, 2013

Update I18n support pradosoft/prado#439

Closed

samdark added 3 commits September 29, 2013 05:05

Renamed test to match class name

b45b16d

better wording

fb68477

typo

abc0df6

samdark reviewed Sep 30, 2013
View reviewed changes

Minor additions to i18n docs

6fc5f0a

samdark mentioned this pull request Oct 10, 2013

Select format isn't supported by IntlFormatter auraphp/Aura.Intl#6

Closed

cebe reviewed Oct 15, 2013
View reviewed changes

cebe added 2 commits October 16, 2013 04:14

a parser that is able to deal with the right number of args

b8099cb

intl message parser now handles too many or too less args

fa9a975

cebe reviewed Oct 16, 2013
View reviewed changes

fixed regex for multiline patterns

150b936

ghost assigned cebe Oct 16, 2013

improved unit tests for ICU message formatter

2eb5abb

adjusted I18N to be consistent with intl message formatting

bbcee32

fixed I18N handling of special param values and broken message tags

5d6bad5

cebe added 3 commits October 16, 2013 22:03

applied new style of Yii::t params to all occurences

6507e2e

changed plural format for BaseListView

677893e

cebe mentioned this pull request Oct 16, 2013

Rethink validator and BaseListView summary parameter replacement #991

Closed

samdark added 2 commits October 17, 2013 00:36

Fixes PHP 5.5 weird placeholder replacememt in case no arguments are …

cdb9fbf

…provided at all (https://bugs.php.net/bug.php?id=65920).

Removed intl version check since it's very inconsistent and it seems …

da8f179

…bundled versions are always the same ones for the same PHP versions

removed needFix method

bf7a084

Better MessageFormatter tests

71e2dcc

Added intl check to tests, better error reporting, credited Aura.Intl…

6b65ef5

… for the most complex test pattern

samdark added a commit that referenced this pull request Oct 16, 2013

Merge pull request #917 from yiisoft/i18n-icu

3667e03

[Work in progress] I18n icu

samdark merged commit 3667e03 into master Oct 16, 2013

samdark deleted the i18n-icu branch October 16, 2013 22:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Work in progress] I18n icu #917

[Work in progress] I18n icu #917

samdark commented Sep 28, 2013

qiangxue Sep 28, 2013

samdark Sep 28, 2013

coveralls commented Sep 28, 2013

qiangxue Sep 28, 2013

samdark Sep 28, 2013

coveralls commented Sep 29, 2013

coveralls commented Sep 29, 2013

samdark Sep 30, 2013

cebe Oct 16, 2013

cebe Oct 15, 2013

samdark Oct 15, 2013

cebe Oct 15, 2013

samdark Oct 15, 2013

cebe Oct 16, 2013

cebe Oct 16, 2013

samdark Oct 16, 2013

iJackUA Oct 16, 2013

cebe Oct 16, 2013

cebe Oct 16, 2013

cebe Oct 29, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

samdark commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

samdark commented Oct 16, 2013

coveralls commented Oct 16, 2013

cebe commented Oct 16, 2013

[Work in progress] I18n icu #917

[Work in progress] I18n icu #917

Conversation

samdark commented Sep 28, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Sep 28, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Sep 29, 2013

coveralls commented Sep 29, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

samdark commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

coveralls commented Oct 16, 2013

samdark commented Oct 16, 2013

coveralls commented Oct 16, 2013

cebe commented Oct 16, 2013